the comments generated by the approval comment generator are a bit hard on the eyes (random example from https://bugzilla.mozilla.org/show_bug.cgi?id=1522810#c12) --- ## Beta/Release Uplift Approval Request ### Feature/Bug causing the regression None ### User impact if declined personalized recommendations would appear in private browsing ### Is this code covered by automated tests? Yes ### Has the fix been verified in Nightly? No ### Needs manual test from QE? No ### If yes, steps to reproduce covered by test, but manual str if desired would be to check for the header via network monitor on a private window. ### List of other uplifts needed None ### Risk to taking this patch Low ### Why is the change risky/not risky? (and alternatives if risky) minimal change ### String changes made/needed none --- playing around it looks a bit more readable with the next step down of headers --- ### Beta/Release Uplift Approval Request #### Feature/Bug causing the regression None #### User impact if declined personalized recommendations would appear in private browsing #### Is this code covered by automated tests? Yes #### Has the fix been verified in Nightly? No #### Needs manual test from QE? No #### If yes, steps to reproduce covered by test, but manual str if desired would be to check for the header via network monitor on a private window. #### List of other uplifts needed None #### Risk to taking this patch Low #### Why is the change risky/not risky? (and alternatives if risky) minimal change #### String changes made/needed none ---
Bug 1524158 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
the comments generated by the approval comment generator are a bit hard on the eyes -=-=-=-=- ## Beta/Release Uplift Approval Request ### Feature/Bug causing the regression None ### User impact if declined personalized recommendations would appear in private browsing ### Is this code covered by automated tests? Yes ### Has the fix been verified in Nightly? No ### Needs manual test from QE? No ### If yes, steps to reproduce covered by test, but manual str if desired would be to check for the header via network monitor on a private window. ### List of other uplifts needed None ### Risk to taking this patch Low ### Why is the change risky/not risky? (and alternatives if risky) minimal change ### String changes made/needed none -=-=-=-=- playing around it looks a bit more readable with the next step down of headers -=-=-=-=- ### Beta/Release Uplift Approval Request #### Feature/Bug causing the regression None #### User impact if declined personalized recommendations would appear in private browsing #### Is this code covered by automated tests? Yes #### Has the fix been verified in Nightly? No #### Needs manual test from QE? No #### If yes, steps to reproduce covered by test, but manual str if desired would be to check for the header via network monitor on a private window. #### List of other uplifts needed None #### Risk to taking this patch Low #### Why is the change risky/not risky? (and alternatives if risky) minimal change #### String changes made/needed none -=-=-=-=-