Bug 1525075 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

[Tracking Requested - why for this release]:

(In reply to Hiroyuki Ikezoe (:hiro) from comment #15)
> and unfortunately we return the minimum scale size width for the clientWidth.

Indeed, it looks like `documentElement.clientWidth`/`clientHeight` [return the scroll port size](https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/dom/base/Element.cpp#1000), which has been modified in bug 1423013 to return the minimum scale size.

I'm going to suggest that we track this for 66, so we don't ship a change in the interpretation of `clientWidth`/`clientHeight` that we didn't intend in 66 only to change it back in 67.

(Another reason for tracking is that Ryan is adding a fast-path to `Element::GetClientAreaRect()` in bug 1520666, which is also tracked for 66, and the correct implementation of that will depend on whether or not this is fixed.)
[Tracking Requested - why for this release]:

(In reply to Hiroyuki Ikezoe (:hiro) from comment #15)
> and unfortunately we return the minimum scale size width for the clientWidth.

Indeed, it looks like `documentElement.clientWidth`/`clientHeight` [return the scroll port size](https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/dom/base/Element.cpp#1000), which has been modified in bug 1423013 to be the minimum scale size.

I'm going to suggest that we track this for 66, so we don't ship a change in the interpretation of `clientWidth`/`clientHeight` that we didn't intend in 66 only to change it back in 67.

(Another reason for tracking is that Ryan is adding a fast-path to `Element::GetClientAreaRect()` in bug 1520666, which is also tracked for 66, and the correct implementation of that will depend on whether or not this is fixed.)
[Tracking Requested - why for this release]:

(In reply to Hiroyuki Ikezoe (:hiro) from comment #15)
> and unfortunately we return the minimum scale size width for the clientWidth.

Indeed, it looks like `documentElement.clientWidth`/`clientHeight` [return the scroll port size](https://searchfox.org/mozilla-central/rev/00c0d068ece99717bea7475f7dc07e61f7f35984/dom/base/Element.cpp#1000), which has been modified in bug 1423013 to be the minimum scale size.

I'm going to suggest that we track this for 66, so we don't ship a change in the interpretation of `clientWidth`/`clientHeight` that we didn't intend in 66 only to change it back in 67.

(Another reason for tracking is that Ryan is adding a fast-path to `Element::GetClientAreaRect()` in bug 1520666 (which is also tracked for 66), and the correct implementation of that will depend on whether or not this is fixed.)

Back to Bug 1525075 Comment 16