Bug 1528059 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I believe this regressed with bug 1479458. It added a `doContentUpdate()` in `SYSTEM_TICK`:

https://github.com/mozilla/activity-stream/commit/be0ccddd3e6f7d7adffa55b0440f8a1104286ca5#diff-ab2f31cc847abe1fcf02369e79b4dd4dR494

And it reads the stories from `this.stories`:

https://github.com/mozilla/activity-stream/commit/be0ccddd3e6f7d7adffa55b0440f8a1104286ca5#diff-ab2f31cc847abe1fcf02369e79b4dd4dR105

… instead of accessing the redux state that has stories removed, e.g.,

```
this.store.getState().Sections.find(s => s.id === SECTION_ID)
```
Revision 1 by
on 
I believe this regressed with bug 1479458 since Firefox 63. It added a `doContentUpdate()` in `SYSTEM_TICK`:

https://github.com/mozilla/activity-stream/commit/be0ccddd3e6f7d7adffa55b0440f8a1104286ca5#diff-ab2f31cc847abe1fcf02369e79b4dd4dR494

And it reads the stories from `this.stories`:

https://github.com/mozilla/activity-stream/commit/be0ccddd3e6f7d7adffa55b0440f8a1104286ca5#diff-ab2f31cc847abe1fcf02369e79b4dd4dR105

… instead of accessing the redux state that has stories removed, e.g.,

```
this.store.getState().Sections.find(s => s.id === SECTION_ID)
```

Back to Bug 1528059 Comment 2