Bug 1529323 Comment 17 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I've been thinking more about this, and I'm wondering if this should be based on the theme ID or based on a certain theme property.

If it's based on the theme ID, then the default theme (default-theme@mozilla.org) would never match, even in dark mode.

If it's based on a theme property (eg. colors.frame), then themes like this one: https://addons.mozilla.org/en-US/firefox/addon/arc-darker/ would always match. I guess the most accurate theme property to be based against would probably be `colors.ntp_background`, since it's the only one that matches content, but that seems pretty wrong too.
I've been thinking more about this, and I'm wondering if this should be based on the theme ID or based on a certain theme property.

If it's based on the theme ID, then the default theme (default-theme@mozilla.org) would never match, even in dark mode.

If it's based on a theme property (eg. `colors.frame`), then themes like this one: https://addons.mozilla.org/en-US/firefox/addon/arc-darker/ would always match. I guess the most accurate theme property to be based against would probably be `colors.ntp_background`, since it's the only one that matches content, but that seems pretty wrong too.

Back to Bug 1529323 Comment 17