Sure this the path ``s/src/jit/arm64/vixl/``` is in [ThirdPartyPaths.txt](https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/tools/rewriting/ThirdPartyPaths.txt#45) but this is not enougth, in order to be taken into account polymorphic matcher [isFirstParty](https://searchfox.org/mozilla-central/source/build/clang-plugin/Utils.h#348) nor [inThirdPartyPath()](https://searchfox.org/mozilla-central/source/build/clang-plugin/Utils.h#348). I think this is implemented as such since we disalow this in third party code as well, why don't we fix the actual problem by replacing ```snprintf``` with ```SprintfLiteral```, like it has been done in [this](https://phabricator.services.mozilla.com/D20401) revision?
Bug 1529650 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Sure this the path ```s/src/jit/arm64/vixl/``` is in [ThirdPartyPaths.txt](https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/tools/rewriting/ThirdPartyPaths.txt#45) but this is not enougth, in order to be taken into account polymorphic matcher [isFirstParty](https://searchfox.org/mozilla-central/source/build/clang-plugin/Utils.h#348) nor [inThirdPartyPath()](https://searchfox.org/mozilla-central/source/build/clang-plugin/Utils.h#348). I think this is implemented as such since we disalow this in third party code as well, why don't we fix the actual problem by replacing ```snprintf``` with ```SprintfLiteral```, like it has been done in [this](https://phabricator.services.mozilla.com/D20401) revision?
Sure the path ```s/src/jit/arm64/vixl/``` is in [ThirdPartyPaths.txt](https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/tools/rewriting/ThirdPartyPaths.txt#45) but this is not enougth, in order to be taken into account polymorphic matcher [isFirstParty](https://searchfox.org/mozilla-central/source/build/clang-plugin/Utils.h#348) nor [inThirdPartyPath()](https://searchfox.org/mozilla-central/source/build/clang-plugin/Utils.h#348). I think this is implemented as such since we disalow this in third party code as well, why don't we fix the actual problem by replacing ```snprintf``` with ```SprintfLiteral```, like it has been done in [this](https://phabricator.services.mozilla.com/D20401) revision?
Sure the path ```s/src/jit/arm64/vixl/``` is in [ThirdPartyPaths.txt](https://searchfox.org/mozilla-central/rev/b36e97fc776635655e84f2048ff59f38fa8a4626/tools/rewriting/ThirdPartyPaths.txt#45) but this is not enougth, in order to be taken into account polymorphic matcher [isFirstParty](https://searchfox.org/mozilla-central/source/build/clang-plugin/Utils.h#348) or [inThirdPartyPath()](https://searchfox.org/mozilla-central/source/build/clang-plugin/Utils.h#348) have to be used, and in our case aren't. I think this is implemented as such since we disalow this in third party code as well, why don't we fix the actual problem by replacing ```snprintf``` with ```SprintfLiteral```, like it has been done in [this](https://phabricator.services.mozilla.com/D20401) revision?