Bug 1529969 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

While looking into this, I stumbled on the [following comment](https://searchfox.org/mozilla-central/rev/9ae20497229225cb3fa729a787791f424ff8087b/browser/components/newtab/content-src/components/Search/Search.jsx#173-176):

```
            This dummy and hidden input below is so we can load ContentSearchUIController.
            Why? It sets --newtab-search-icon for us and it isn't trivial to port over.
```

It looks like that's the only bit that we actually need from ContentSearch when the handoff is enabled. With that in mind, would it make sense to do the (non-trivial) porting work to use something like `--newtab-search-icon` in the handoff version of the search box? Comment 0 mentions that this bug would also help the non-handoff case, but isn't sure if that's a priority going forward. I could also work on improving the ContentSearch implementation so this applies to both versions, though that might be a waste of effort if the non-handoff case is going away.

Any thoughts here?
While looking into this, I stumbled on the [following comment](https://searchfox.org/mozilla-central/rev/9ae20497229225cb3fa729a787791f424ff8087b/browser/components/newtab/content-src/components/Search/Search.jsx#173-176):

```
            This dummy and hidden input below is so we can load ContentSearchUIController.
            Why? It sets --newtab-search-icon for us and it isn't trivial to port over.
```

It looks like that's the only bit that we actually need from ContentSearch when the handoff is enabled. With that in mind, would it make sense to do the (non-trivial) porting work to use something like `--newtab-search-icon` in the handoff version of the search box? Comment 0 mentions that fixing this bug could also help the non-handoff case, but isn't sure if that's a priority going forward. While I could work on improving the ContentSearch implementation so this applies to both versions, that might be a waste of effort if the non-handoff case is going away.

Any thoughts here?

Back to Bug 1529969 Comment 1