Bugzilla

I've addressed Magnus' comments and made a few more minor improvements while I was at it. Magnus wrote:
 
> For the patch, there's a bunch of aParams used which would be converted, and for the JSDoc there is some inconsistence in capitalizing string/Number etc. Not sure which is the "right" way.

I've removed the aParam style.  On JSDoc capitalization, I've been following http://usejsdoc.org

I looked into the reason for the differences in capitalization, and it's due to JavaScript's naming primitive types with lowercase (string, boolean, number, null) and object types with uppercase (Object, Array, Event, String).  (See section "2.3 A word on types" here: http://2ality.com/2011/08/jsdoc-intro.html )  So it seems the "right way" is uppercase or lowercase depending on the type.  I checked and everything looks correct to me.

I've addressed Magnus' comments, rebased on trunk, and made a few more minor improvements while I was at it. Magnus wrote:
 
> For the patch, there's a bunch of aParams used which would be converted, and for the JSDoc there is some inconsistence in capitalizing string/Number etc. Not sure which is the "right" way.

I've removed the aParam style.  On JSDoc capitalization, I've been following http://usejsdoc.org

I looked into the reason for the differences in capitalization, and it's due to JavaScript's naming primitive types with lowercase (string, boolean, number, null) and object types with uppercase (Object, Array, Event, String).  (See section "2.3 A word on types" here: http://2ality.com/2011/08/jsdoc-intro.html )  So it seems the "right way" is uppercase or lowercase depending on the type.  I checked and everything looks correct to me.

I've addressed Magnus' comments, rebased on trunk, and made a few more minor improvements while I was at it. Calendar mozmill tests are all passing locally. Magnus wrote:
 
> For the patch, there's a bunch of aParams used which would be converted, and for the JSDoc there is some inconsistence in capitalizing string/Number etc. Not sure which is the "right" way.

I've removed the aParam style.  On JSDoc capitalization, I've been following http://usejsdoc.org

I looked into the reason for the differences in capitalization, and it's due to JavaScript's naming primitive types with lowercase (string, boolean, number, null) and object types with uppercase (Object, Array, Event, String).  (See section "2.3 A word on types" here: http://2ality.com/2011/08/jsdoc-intro.html )  So it seems the "right way" is uppercase or lowercase depending on the type.  I checked and everything looks correct to me.