### Beta/Release Uplift Approval Request * **Feature/Bug causing the regression**: None * **User impact if declined**: We want to separate the GLS and safebrowsing to disable the old key. Not doing it so would be costly. * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: No * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: * Look at about:support to see if GLS and safebrowsing are separated * Check that geolocation still works * Check that safebrowsing still works * **List of other uplifts needed**: Bug 1531178 * **Risk to taking this patch**: Medium * **Why is the change risky/not risky? (and alternatives if risky)**: Well understood change but we had so many surprises ... * **String changes made/needed**: Yes but we can live with the english string in about:support in beta and release (I already told Flod) ### ESR Uplift Approval Request * **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: The same key is used for ESR * **User impact if declined**: Same as beta * **Fix Landed on Version**: nightly * **Risk to taking this patch**: Medium * **Why is the change risky/not risky? (and alternatives if risky)**: see above * **String or UUID changes made by this patch**: see above
Bug 1531176 Comment 20 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
### Beta/Release Uplift Approval Request * **Feature/Bug causing the regression**: None * **User impact if declined**: We want to separate the GLS and safebrowsing to disable the old key. Not doing it so would be costly. * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: No * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: - Look at about:support to see if GLS and safebrowsing are separated - Check that geolocation still works - Check that safebrowsing still works * **List of other uplifts needed**: Bug 1531178 * **Risk to taking this patch**: Medium * **Why is the change risky/not risky? (and alternatives if risky)**: Well understood change but we had so many surprises ... * **String changes made/needed**: Yes but we can live with the english string in about:support in beta and release (I already told Flod) ### ESR Uplift Approval Request * **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: The same key is used for ESR * **User impact if declined**: Same as beta * **Fix Landed on Version**: nightly * **Risk to taking this patch**: Medium * **Why is the change risky/not risky? (and alternatives if risky)**: see above * **String or UUID changes made by this patch**: see above