As the proposed code is now, a user could go into the config editor and "reset" mail.server.default.clientid and on next startup you would then be sending a different clientid for imap. It wouldn'd affect smtp if you did that I think. But it would if you reset mail.smptserver.default.clientid.
Bug 1532388 Comment 151 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
As the proposed code is now, a user could go into the config editor and "reset" mail.server.default.clientid and on next startup you would then be sending a different clientid for imap. It wouldn'd affect smtp if you did that I think. But it would if you reset mail.smptserver.default.clientid. Edit: I stated this wrong. That is what would happen with Magnus's proposed way. With the code the way it is proposed by LinuxMagic, this would not happen. Resetting the "default" would not affect the individual server settings. Also, the individual server setting could be set to custom values (non-default) without the user having to define new prefs. It wouldn't preclude a future UI to set them either.