Bug 1532993 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Added some logs on try, it seems that during this test an extra rendering of the WaterfallView is triggered by a "resize" event fired by its MarkerDetails widget. MarkerDetails can fire resize for 3 reasons:
- click on splitter
- calling the `hidden` setter
- window resize

This "resize" event seems to be fired when the JsFlameGraph is rendered. This FlameGraph relies on the Graphs.js file modified in my patch. A new try push is ongoing to determine which one of them is responsible for the extra event. Possible explanation would be that using DOMHelpers to load the FlameGraph is slightly slower than the previous approach and might trigger a window resize. 

If that's the case, I think it would be valid valid to accept both 4 or 3 renderings of WaterfallView.
Added some logs on try, it seems that during this test an extra rendering of the WaterfallView is triggered by a "resize" event fired by its MarkerDetails widget. MarkerDetails can fire resize for 3 reasons:
- click on splitter
- calling the `hidden` setter
- window resize

This "resize" event seems to be fired when the JsFlameGraph is rendered. This FlameGraph relies on the Graphs.js file modified in my patch. A new try push is ongoing to determine which one of them is responsible for the extra event. Possible explanation would be that using DOMHelpers to load the FlameGraph is slightly slower than the previous approach and might trigger a window resize. 

If that's the case, I think it would be valid valid to accept both 4 or 3 renderings of WaterfallView.

new try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0de1a68231bab9e26fe5b772c426cb82a919520

Back to Bug 1532993 Comment 12