Bug 1533043 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commentor’s name and original timestamp.

The main problem that needs to be solved is the dependency on flask. This is currently installed by the |mach try chooser| command at runtime:
https://searchfox.org/mozilla-central/source/tools/tryselect/mach_commands.py#246

But since we won't be running the test through the mach command, we'll never install flask into the virtualenv. We be pinning this and using hashes anyway.

Couple options:

A) Vendor flask
B) Create requirements.txt (with hashes) and add ability to install these to |mach python-test|
C) Do something with pipenv?

A would be the easiest, but I'm leaning towards B. Would be good to have this ability for other things as well.
The main problem that needs to be solved is the dependency on flask. This is currently installed by the |mach try chooser| command at runtime:
https://searchfox.org/mozilla-central/source/tools/tryselect/mach_commands.py#246

But since we won't be running the test through the mach command, we'll never install flask into the virtualenv. We should be pinning this and using hashes anyway.

Couple options:

A) Vendor flask
B) Create requirements.txt (with hashes) and add ability to install these to |mach python-test|
C) Do something with pipenv?

A would be the easiest, but I'm leaning towards B. Would be good to have this ability for other things as well.

Back to Bug 1533043 Comment 0