Bug 1533958 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Arthur Iakab [arthur_iakab] from comment #5)
> Backed out changeset 239751330c09 (bug 1533958) for causing browser chrome leaks on browser_event_listener.js CLOSED TREE
> 
> Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/b1d382dd18da4460ac88849c12049fa6d1a4cee2
> 
> Failures https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=b439d3fd8862e709eae9525791780b61ac98dbf1&selectedJob=249439400&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29
> 
> Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=249453447&revision=239751330c09bdb7d1ea2ad2cd87685e936c0007
> 
> Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=249439400&repo=mozilla-inbound
> 
> Abdoulaye O. LY can you please take a look?

Sure, I am working on it.

> 
> From talking to rhunt, I think BrowserParent::TransformChildToParent would be helpful here for getting the correct coordinate to place the popup at.
Yes, that seems like a better idea. Are you going to provide an API for this?
(In reply to Arthur Iakab [arthur_iakab] from comment #5)
> Backed out changeset 239751330c09 (bug 1533958) for causing browser chrome leaks on browser_event_listener.js CLOSED TREE
> 
> Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/b1d382dd18da4460ac88849c12049fa6d1a4cee2
> 
> Failures https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=b439d3fd8862e709eae9525791780b61ac98dbf1&selectedJob=249439400&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29
> 
> Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=249453447&revision=239751330c09bdb7d1ea2ad2cd87685e936c0007
> 
> Failure logs https://treeherder.mozilla.org/logviewer.html#?job_id=249439400&repo=mozilla-inbound
> 
> Abdoulaye O. LY can you please take a look?

Sure, I am working on it.

> 
> From talking to rhunt, I think BrowserParent::TransformChildToParent would be helpful here for getting the correct coordinate to place the popup at.

Yes, that seems like a better idea. Are you going to provide an API for this?

Back to Bug 1533958 Comment 7