Bug 1536871 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

> Adapting the font inspector UI to have a keyword control would be the correct thing, but I have no idea of how to do that.

We have a similar treatment for the React component corresponding to `letter-spacing` to [handle keywords such as "normal"](https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/devtools/client/inspector/fonts/components/LetterSpacing.js#56-59,91) (I just noticed there's leftover naming as `LineHeight` instead of `LetterSpacing` in that component due to forking the original `LineHeight.js` component; apologies for the confusion. I'll fix that.) We can adapt the component for `line-height` to accept "normal" as a value.

We also need to handle that [unitless conversion you pointed to](https://searchfox.org/mozilla-central/rev/1133b6716d9a8131c09754f3f29288484896b8b6/devtools/client/inspector/fonts/fonts.js#318) in the font editor setup phase to watch out for keyword values (it now assumes gCS will return a numeric value)

I can work on this. With travel and the All Hands event coming up next week, I may be slower to do this. Let me know if this requires added urgency.
> Adapting the font inspector UI to have a keyword control would be the correct thing, but I have no idea of how to do that.

We have a similar treatment for the React component corresponding to `letter-spacing` to [handle keywords such as "normal"](https://searchfox.org/mozilla-central/rev/d62176d3d70bbf9ad86a5d444f9edada52cbc2b1/devtools/client/inspector/fonts/components/LetterSpacing.js#56-59,91) (I just noticed there's leftover naming as `LineHeight` instead of `LetterSpacing` in that component due to forking the original `LineHeight.js` component; apologies for the confusion. I'll fix that.) We can adapt the component for `line-height` to accept "normal" as a value.

We also need to handle that [unitless conversion you pointed to](https://searchfox.org/mozilla-central/rev/1133b6716d9a8131c09754f3f29288484896b8b6/devtools/client/inspector/fonts/fonts.js#318) in the font editor setup phase to watch out for keyword values (it now assumes gCS will return a numeric value)

I can work on this in bug 1559589. 
With travel and the All Hands event coming up next week, I may be slower to do this. Let me know if this requires added urgency.

Back to Bug 1536871 Comment 18