Bug 1538375 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

We currently deoptimize pretty hard when we see a `debugger;` statement. It's about as bad as direct `eval`. Bug 1537609 indicates that this is a real performance problem.

There's no compelling reason for us to do it, either. It's not like a Web developer using the Debugger will always, or even *usually*, have a `debugger` statement in the function they want to debug.

If I tear it out, we fail 11 tests under js/src/jit-test/tests/debug. (All other JS shell tests still pass.) Pretty sure I can make all those pass again just by adding `eval("");` nearby. Or, you know, I could actually look at them and debug some stuff...
We currently deoptimize pretty hard when we see a `debugger;` statement. It's about as bad as direct `eval`. Bug 1537609 indicates that this is a real performance problem.

There's no compelling reason for us to do it, either. It's not like a Web developer using the Debugger will always, or even *usually*, have a `debugger` statement in the function they want to debug.

If I tear it out, we fail 10 tests under js/src/jit-test/tests/debug. (All other JS shell tests still pass.) Pretty sure I can make all those pass again just by adding `eval("");` nearby. Or, you know, I could actually look at them and debug some stuff...

Back to Bug 1538375 Comment 0