Bug 1542830 Comment 44 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

For the record,
[this](https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=85248a084397f1823cb4da7f0b10eb351973674e&tochange=b295a3c77fb1e03874d675d074b7441cb1ef5c7a)
(In reply to Pulsebot from comment #39)
> Pushed by aklotz@mozilla.com:
> https://hg.mozilla.org/integration/autoland/rev/da7e775c4051
> Part 1 - Updates to NativeNt.h; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/919f1af7c135
> Part 2 - Modify launcher process blocklist to collect information about
> untrusted module loads; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/c4e547a6a039
> Part 3 - Add ntdll_freestanding.lib to freestanding; r=mhowell,froydnj
> https://hg.mozilla.org/integration/autoland/rev/8e2da9ff5f5a
> Part 4 - Modify mozglue to use new untrusted modules interfaces; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/84b903e60dc9
> Part 5 - Make ModuleVersion copyable and movable; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/73ec288886cd
> Part 6 - Rewrite the untrusted modules processor in toolkit/xre; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/1aa253e6604a
> Part 7 - Support MFBT Vector in ProcessedStack and add Swap operation to
> CombinedStacks; r=janerik
> https://hg.mozilla.org/integration/autoland/rev/6fcb417f7ff4
> Part 8 - Rename the "untrustedModules" ping to "third-party-modules" and
> change the schema to support multiprocess; r=janerik
cause this regression:
== Change summary for alert #23177 (as of Sat, 21 Sep 2019 13:31:43 GMT) ==

Regressions:

  46%  tp5n nonmain_normal_fileio windows10-64-shippable opt e10s stylo        352,415,047.58 -> 513,380,308.75
  38%  tp5n nonmain_normal_fileio windows10-64-shippable-qr opt e10s stylo     376,501,507.08 -> 520,844,282.08
  13%  tp5n nonmain_normal_fileio windows7-32-shippable opt e10s stylo         376,185,697.08 -> 425,389,093.33

Improvements:

  26%  tp5n main_startup_fileio windows10-64-shippable-qr opt e10s stylo     1,000,273.67 -> 744,551.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23177

And [this](https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=378901831720b88f4c11a79a97475f85ab57d137&tochange=9c1f03ad76dc13caa05de8ebc172e36ef627da29):
(In reply to Cristian Brindusan [:cbrindusan] from comment #41)
> Backed out 8 changesets (Bug 1542830) for causing Nightly bustages.
> 
> Backout: https://hg.mozilla.org/mozilla-central/rev/2b745a11bb29bd2e4b56f13ab7e9ea211ffed3fb

caused this:
== Change summary for alert #23189 (as of Mon, 23 Sep 2019 04:57:21 GMT) ==

Regressions:

  36%  tp5n main_startup_fileio windows10-64-shippable-qr opt e10s stylo     743,832.23 -> 1,013,649.67

Improvements:

  30%  tp5n nonmain_normal_fileio windows10-64-shippable-qr opt e10s stylo     521,883,205.67 -> 365,219,723.50
  28%  tp5n nonmain_normal_fileio windows10-64-shippable opt e10s stylo        513,743,420.08 -> 367,859,744.75
  12%  tp5n nonmain_normal_fileio windows7-32-shippable opt e10s stylo         422,292,007.17 -> 369,942,939.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23189
For the record,
[this](https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=85248a084397f1823cb4da7f0b10eb351973674e&tochange=b295a3c77fb1e03874d675d074b7441cb1ef5c7a)
(In reply to Pulsebot from comment #39)
> Pushed by aklotz@mozilla.com:
> https://hg.mozilla.org/integration/autoland/rev/da7e775c4051
> Part 1 - Updates to NativeNt.h; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/919f1af7c135
> Part 2 - Modify launcher process blocklist to collect information about
> untrusted module loads; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/c4e547a6a039
> Part 3 - Add ntdll_freestanding.lib to freestanding; r=mhowell,froydnj
> https://hg.mozilla.org/integration/autoland/rev/8e2da9ff5f5a
> Part 4 - Modify mozglue to use new untrusted modules interfaces; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/84b903e60dc9
> Part 5 - Make ModuleVersion copyable and movable; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/73ec288886cd
> Part 6 - Rewrite the untrusted modules processor in toolkit/xre; r=mhowell
> https://hg.mozilla.org/integration/autoland/rev/1aa253e6604a
> Part 7 - Support MFBT Vector in ProcessedStack and add Swap operation to
> CombinedStacks; r=janerik
> https://hg.mozilla.org/integration/autoland/rev/6fcb417f7ff4
> Part 8 - Rename the "untrustedModules" ping to "third-party-modules" and
> change the schema to support multiprocess; r=janerik

cause this regression:
== Change summary for alert #23177 (as of Sat, 21 Sep 2019 13:31:43 GMT) ==

Regressions:

  46%  tp5n nonmain_normal_fileio windows10-64-shippable opt e10s stylo        352,415,047.58 -> 513,380,308.75
  38%  tp5n nonmain_normal_fileio windows10-64-shippable-qr opt e10s stylo     376,501,507.08 -> 520,844,282.08
  13%  tp5n nonmain_normal_fileio windows7-32-shippable opt e10s stylo         376,185,697.08 -> 425,389,093.33

Improvements:

  26%  tp5n main_startup_fileio windows10-64-shippable-qr opt e10s stylo     1,000,273.67 -> 744,551.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23177

And [this](https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=378901831720b88f4c11a79a97475f85ab57d137&tochange=9c1f03ad76dc13caa05de8ebc172e36ef627da29):
(In reply to Cristian Brindusan [:cbrindusan] from comment #41)
> Backed out 8 changesets (Bug 1542830) for causing Nightly bustages.
> 
> Backout: https://hg.mozilla.org/mozilla-central/rev/2b745a11bb29bd2e4b56f13ab7e9ea211ffed3fb

caused this:
== Change summary for alert #23189 (as of Mon, 23 Sep 2019 04:57:21 GMT) ==

Regressions:

  36%  tp5n main_startup_fileio windows10-64-shippable-qr opt e10s stylo     743,832.23 -> 1,013,649.67

Improvements:

  30%  tp5n nonmain_normal_fileio windows10-64-shippable-qr opt e10s stylo     521,883,205.67 -> 365,219,723.50
  28%  tp5n nonmain_normal_fileio windows10-64-shippable opt e10s stylo        513,743,420.08 -> 367,859,744.75
  12%  tp5n nonmain_normal_fileio windows7-32-shippable opt e10s stylo         422,292,007.17 -> 369,942,939.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=23189

Back to Bug 1542830 Comment 44