Bug 1542844 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
there are two problems here:
* wizard-buttons CE has wrong attribute inheritance, here's a fix:

@@ -56,18 +58,18 @@ class MozWizardButtons extends MozXULEle
       if (btn) {
         btn.addEventListener("command", listener);
       }
     }
   }
 
   static get inheritedAttributes() {
     return AppConstants.platform == "macosx" ? {
-      "[dlgtype='finish']": "hidefinishbutton",
-      "[dlgtype='next']": "lastpage",
+      "[dlgtype='finish']": "hidden=hidefinishbutton",
+      "[dlgtype='next']": "hidden=lastpage",
     } : null;
   }
 
   get _markup() {
     if (AppConstants.platform == "macosx") {
       return `
         <vbox flex="1">
           <hbox class="wizard-buttons-btm">

* @hidefinishbutton attribute is changed (onPageChange method is called) after attribute inheritance was initialized (i.e. initializeAttributeInheritance called, but before the CE is connected (isConnectedAndReady is false).

Brian, I assume attributeChangedCallback should have isConnectedAndReady check, otherwise we may miss attributes changing, correct?
Revision 1 by
on 
there are two problems here:
* wizard-buttons CE has wrong attribute inheritance, here's a fix:

```
@@ -56,18 +58,18 @@ class MozWizardButtons extends MozXULEle
       if (btn) {
         btn.addEventListener("command", listener);
       }
     }
   }
 
   static get inheritedAttributes() {
     return AppConstants.platform == "macosx" ? {
-      "[dlgtype='finish']": "hidefinishbutton",
-      "[dlgtype='next']": "lastpage",
+      "[dlgtype='finish']": "hidden=hidefinishbutton",
+      "[dlgtype='next']": "hidden=lastpage",
     } : null;
   }
 
   get _markup() {
     if (AppConstants.platform == "macosx") {
       return `
         <vbox flex="1">
           <hbox class="wizard-buttons-btm">
```

* @hidefinishbutton attribute is changed (onPageChange method is called) after attribute inheritance was initialized (i.e. initializeAttributeInheritance called, but before the CE is connected (isConnectedAndReady is false).

Brian, I assume attributeChangedCallback should have isConnectedAndReady check, otherwise we may miss attributes changing, correct?

Back to Bug 1542844 Comment 5