Bugzilla

This basically does for app update what bug 1496632 did for add-ons.

The pref removals in all-thunderbird.js are for prefs that the code that use them was removed a very long time ago.

The change to the app.update.staging.enabled pref is because staging was enabled on all platforms after I fixed a couple of bugs.

I went with initializing AppUpdateUI.jsm in _onProfileStartup because there are cases where the notification can happen earlier than _onMailStartupDone.

AppUpdateUI.jsm does most of what toolkit/mozapps/update/UpdateListener.jsm does except it uses GlobalPopupNotifications.jsm instead of AppMenuNotifications.jsm.

The strings are the same or close to the same as the strings Firefox uses.

The images are the same as the ones Firefox uses but I changed their name from update.svg to app-update.svg and update-badge.svg to app-update.svg in case I move these files into toolkit to lessen confusion.

There was some missing css in messenger.css that prevent the anchor icon from not being displayed when the anchor didn't have notifications associated with it which I've added. I also moved the images into css so it is able to override the images with css.

I have one more notification for elevation requests that I'll add in another bug for both Firefox and Thunderbird.

Feel free to change the images but I'd prefer if that were done in another bug so this doesn't hold up other planned work in toolkit/mozapps/update/

This basically does for app update what bug 1496632 did for add-ons.

The pref removals in all-thunderbird.js are for prefs that the code that used them was removed a very long time ago.

The change to the app.update.staging.enabled pref is because staging was enabled on all platforms after I fixed a couple of bugs.

I went with initializing AppUpdateUI.jsm in _onProfileStartup because there are cases where the notification can happen earlier than _onMailStartupDone.

AppUpdateUI.jsm does most of what toolkit/mozapps/update/UpdateListener.jsm does except it uses GlobalPopupNotifications.jsm instead of AppMenuNotifications.jsm.

The strings are the same or close to the same as the strings Firefox uses.

The images are the same as the ones Firefox uses but I changed their name from update.svg to app-update.svg and update-badge.svg to app-update.svg in case I move these files into toolkit to lessen confusion.

There was some missing css in messenger.css that prevent the anchor icon from not being displayed when the anchor didn't have notifications associated with it which I've added. I also moved the images into css so it is able to override the images with css.

I have one more notification for elevation requests that I'll add in another bug for both Firefox and Thunderbird.

Feel free to change the images but I'd prefer if that were done in another bug so this doesn't hold up other planned work in toolkit/mozapps/update/

This basically does for app update what bug 1496632 did for add-ons.

The pref removals in all-thunderbird.js are for prefs that the code that used them was removed a very long time ago.

The change to the app.update.staging.enabled pref is because staging was enabled on all platforms after I fixed a couple of bugs.

I went with initializing AppUpdateUI.jsm in _onProfileStartup because there are cases where the notification can happen earlier than _onMailStartupDone.

AppUpdateUI.jsm does most of what toolkit/mozapps/update/UpdateListener.jsm does except it uses GlobalPopupNotifications.jsm instead of AppMenuNotifications.jsm.

The strings are the same or close to the same as the strings Firefox uses.

The images are the same as the ones Firefox uses but I changed their name from update.svg to app-update.svg and update-badge.svg to app-update.svg in case I move these files into toolkit to lessen confusion.

There was some missing css in messenger.css that prevents the anchor icon from not being displayed when the anchor didn't have notifications associated with it. I also moved the images into css so it is possible to override the images with css.

I have one more notification for elevation requests that I'll add in another bug for both Firefox and Thunderbird.

Feel free to change the images but I'd prefer if that were done in another bug so this doesn't hold up other planned work in toolkit/mozapps/update/