Bug 1549475 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #3)

> Mind filing those bugs, so that it is clear from the dependency
> tree what still has to be done?

We have a meta bug for each command and event, but beyond that it’s
hard to tell upfront how the implementation work will be structured.

In some cases it makes sense to implement command parameters
individually as one, logical chunk (for example [`Page.navigate`’s
`ignoreCache`]).  But frequently you might cover several parameters,
if not all, when you add support for a command.  It’s also not given
that we want to implement everything that CDP does, so I think this
to be approached on a case-by-case basis.

In the case of `Page.navigate`, there’s `referrer`, `transitionType`,
and `frameId`, but we haven’t run into cases in the Gutenberg- or
Puppeteer test suites that require them yet.

[`Page.navigate`’s `ignoreCache`]: https://bugzilla.mozilla.org/show_bug.cgi?id=1549708
Revision 1 by
on 
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #3)

> Mind filing those bugs, so that it is clear from the dependency
> tree what still has to be done?

We have a meta bug for each command and event, but beyond that it’s
hard to tell upfront how the implementation work will be structured.

In some cases it makes sense to implement command parameters
individually as one, logical chunk (for example [`Page.navigate`’s
`ignoreCache`]).  But frequently you might cover several parameters,
if not all, when you add support for a command.  It’s also not given
that we want to implement everything that CDP does, so I think this
by necessitty has to be approached on a case-by-case basis.

In the case of `Page.navigate`, there’s `referrer`, `transitionType`,
and `frameId`, but we haven’t run into cases in the Gutenberg- or
Puppeteer test suites that require them yet.

[`Page.navigate`’s `ignoreCache`]: https://bugzilla.mozilla.org/show_bug.cgi?id=1549708
Revision 2 by
on 
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #3)

> Mind filing those bugs, so that it is clear from the dependency
> tree what still has to be done?

We have a meta bug for each command and event, but beyond that it’s
hard to tell upfront how the implementation work will be structured.

In some cases it makes sense to implement command parameters
individually as one, logical chunk (for example [`Page.navigate`’s
`ignoreCache`]).  But frequently you might cover several parameters,
if not all, when you add support for a command.  It’s also not given
that we want to implement everything that CDP does, so I think this
by necessity has to be approached on a case-by-case basis.

In the case of `Page.navigate`, there’s `referrer`, `transitionType`,
and `frameId`, but we haven’t run into cases in the Gutenberg- or
Puppeteer test suites that require them yet.

[`Page.navigate`’s `ignoreCache`]: https://bugzilla.mozilla.org/show_bug.cgi?id=1549708

Back to Bug 1549475 Comment 4