Bug 1550611 Comment 32 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Jorg K (GMT+2) from comment #31)
> I guess you're referring to: "Sets "always_target" to true on shippable platforms when running a nightly build."
> 
> So let's fix this before landing this.

I will address the comment issue. The other thing  is bug 1592162, I need to add to that so Geoff can review before this one works.
(In reply to Jorg K (GMT+2) from comment #31)
> I guess you're referring to: "Sets "always_target" to true on shippable platforms when running a nightly build."
> 
> So let's fix this before landing this.

I will address the comment issue. The other thing  is bug 1592162, I need to add to that so Geoff can review before this one works.

A corner case just occurred to me... I need to work on this some more.

When a release is promoted, all of those promotion tasks are going to depend on a "shippable" build. But it may or may not be a nightly build that gets promoted and with this function written like this I believe we are going to see a problem with tests. That should be limited to Seamonkey only pushes. Not likely to happen, but if it's not too hard I would like to address it.

Back to Bug 1550611 Comment 32