Bug 1550945 Comment 53 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Review of attachment 9068932 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/nsNetUtil.cpp
@@ +1867,5 @@
>    }
>  
> +#if defined(MOZ_THUNDERBIRD) || defined(MOZ_SUITE)
> +  rv = NS_NewMailnewsURI(aURI, aSpec, aCharset, aBaseURI, aIOService);
> +  if (NS_SUCCEEDED(rv)) return rv;

This should be 
```
if (rv != NS_UNKNOWN_PROTOCOL) {
  return rv;
}```

And make sure to return NS_UNKNOWN_PROTOCOL at the end of NS_NewMailnewsURI
Revision 1 by
on 
Review of attachment 9068932 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/nsNetUtil.cpp
@@ +1867,5 @@
>    }
>  
> +#if defined(MOZ_THUNDERBIRD) || defined(MOZ_SUITE)
> +  rv = NS_NewMailnewsURI(aURI, aSpec, aCharset, aBaseURI, aIOService);
> +  if (NS_SUCCEEDED(rv)) return rv;

This should be 
```C++
if (rv != NS_UNKNOWN_PROTOCOL) {
  return rv;
}
```

And make sure to return NS_UNKNOWN_PROTOCOL at the end of NS_NewMailnewsURI

Back to Bug 1550945 Comment 53