Bug 1551520 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Dzmitry Malyshau [:kvark] from comment #3)
> I took a stab at fixing the performance regression as opposed to backing out the original (large) change, and I ended up with a very tiny fix that just landed in https://phabricator.services.mozilla.com/D32195 . The Talos results so far confirm this in https://treeherder.mozilla.org/#/jobs?repo=try&collapsedPushes=480100&selectedJob=247829360&revision=966241befa0bdc998d07a13141f359439b5a2403 , I believe.

Could you also push the baseline on Try *(the original patch you applied your fix on)*, so I can properly confirm the fix?

> :igoldan do I understand correctly that now we need this fix backported to beta?

I don't demand that, though it would be nice. I believe this depends whether there are any risks on uplifting this to beta.
(In reply to Dzmitry Malyshau [:kvark] from comment #3)
> I took a stab at fixing the performance regression as opposed to backing out the original (large) change, and I ended up with a very tiny fix that just landed in https://phabricator.services.mozilla.com/D32195 . The Talos results so far confirm this in https://treeherder.mozilla.org/#/jobs?repo=try&collapsedPushes=480100&selectedJob=247829360&revision=966241befa0bdc998d07a13141f359439b5a2403 , I believe.

Could you also push the baseline on Try *(the original patch you applied your fix on)* & then share that Treeherder link, so I can properly confirm the fix?

> :igoldan do I understand correctly that now we need this fix backported to beta?

I don't demand that, though it would be nice. I believe this depends whether there are any risks on uplifting this to beta.

Back to Bug 1551520 Comment 4