Bug 1552344 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

> Can you check that cherry-picking these patches catch the bug?

Checked the patches based on offset-distance, and run the test. Got something like this:
```
Unexpected Results
------------------
layout/style/test/test_computed_style_difference.html
  FAIL ... (other fails)
  FAIL Diffing for offset-distance - Diffing for offset-distance: assert_equals: Didn't handle the inherited change correctly? expected "10px" but got "0px"
```

Yes, this test (i.e. these patches) catches this problem. :)
(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

> Can you check that cherry-picking these patches catch the bug?

Checked the patches based on offset-distance, and run the test. Got something like this:
```
Unexpected Results
------------------
layout/style/test/test_computed_style_difference.html
  FAIL ... (other fails)
  FAIL Diffing for offset-distance - Diffing for offset-distance: assert_equals: Didn't handle the inherited change correctly? expected "10px" but got "0px"
```

Yes, this test (i.e. these patches) catches this bug. :)
(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

> Can you check that cherry-picking these patches catch the bug?

Checked the patches based on offset-distance, and run the test. Got something like this:
```
Unexpected Results
------------------
layout/style/test/test_computed_style_difference.html
  FAIL Diffing for offset-distance - Diffing for offset-distance: assert_equals: Didn't handle the inherited change correctly? expected "10px" but got "0px"
```

Yes, this test (i.e. these patches) catches this bug. :)

Back to Bug 1552344 Comment 6