I had what I thought was a fairly good and elegant attempt at preventing this `compiz` error in this push: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=pending%2Crunning%2Csuperseded%2Cusercancel%2Cretry%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&revision=9a15447e319eb34f081fbd36ece77e3440035d8f&searchStr=linux64%2Fopt&selectedJob=246988518 However, turns out there's a problem with parsing `mozharness_args`, since not all suites pass in arguments that is necessary for this code section to work: ``` declare -a REQUIRES_COMPIZ=("mochitest-plain" "mochitest-browser-chrome-chunked" "mochitest-devtools-chrome-chunked" "mochitest-chrome" "mochitest-a11y" "wdspec" ) # only start compiz (which is time consuming) if it's actually required. for test_suite in "${REQUIRES_COMPIZ[@]}"; do if [[ "${@}" == *$test_suite* ]]; then # start compiz for our window manager compiz 2>&1 & break; fi done ``` Examples of tests that do not pass in `mozharness_args` in a nice format are `web-platform-tests`, `firefox-ui-functional-remote` and `marionette`. This approach (of detecting in shell script) thus won't work.
Bug 1552563 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I had what I thought was a fairly good and elegant attempt at preventing this `compiz` error in this push: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=pending%2Crunning%2Csuperseded%2Cusercancel%2Cretry%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&revision=9a15447e319eb34f081fbd36ece77e3440035d8f&searchStr=linux64%2Fopt&selectedJob=246988518 However, turns out there's a problem with parsing `mozharness_args`, since not all suites pass in arguments that is necessary for this code section to work: ``` declare -a REQUIRES_COMPIZ=("mochitest-plain" "mochitest-browser-chrome-chunked" "mochitest-devtools-chrome-chunked" "mochitest-chrome" "mochitest-a11y" "wdspec" ) # only start compiz (which is time consuming) if it's actually required. for test_suite in "${REQUIRES_COMPIZ[@]}"; do if [[ "${@}" == *$test_suite* ]]; then # start compiz for our window manager compiz 2>&1 & break; fi done ``` Examples of tests that do not pass in `mozharness_args` in a nice format are `web-platform-tests`, `firefox-ui-functional-remote` and `marionette`. These are not caught by the whitelist `REQUIRES_COMPIZ` and thus compiz is not started, and tests fail. This approach (of detecting in shell script) thus won't work.