Bug 1553454 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Johann Hofmann [:johannh] from comment #5)
> What's that workaround? :)
I've removed CLEAR_HISTORY from the flags passed by default, see `GeckoViewStorageController.jsm` changes in the patch here.

(In reply to Marco Bonardo [::mak] from comment #6)
> Isn't GeckoView Android only? Places is a desktop only history implementation, mobile has different implementations (Fenix has a new Rust based one, the Firefox for Android has its own history impl, as well as Firefox for IOS). If you're going to expose nsIClearDataService completely, you must ensure the proper services are used on different devices, PlacesUtils surely doesn't work out of desktop.
> Basically, HistoryCleaner in ClearDataService.jsm is currently not cross-platform, someone should add support for the other systems to it.

We're not exposing `nsIClearDataService` completely, the issue was that the catch-all flag `CLEAR_ALL` included `CLEAR_HISTORY` so we hit the path with the missing `PlacesUtils` file.
Revision 1 by
on 
(In reply to Johann Hofmann [:johannh] from comment #5)
> What's that workaround? :)

I've removed CLEAR_HISTORY from the flags passed by default, see `GeckoViewStorageController.jsm` changes in the patch here.

(In reply to Marco Bonardo [::mak] from comment #6)
> Isn't GeckoView Android only? Places is a desktop only history implementation, mobile has different implementations (Fenix has a new Rust based one, the Firefox for Android has its own history impl, as well as Firefox for IOS). If you're going to expose nsIClearDataService completely, you must ensure the proper services are used on different devices, PlacesUtils surely doesn't work out of desktop.
> Basically, HistoryCleaner in ClearDataService.jsm is currently not cross-platform, someone should add support for the other systems to it.

We're not exposing `nsIClearDataService` completely, the issue was that the catch-all flag `CLEAR_ALL` included `CLEAR_HISTORY` so we hit the path with the missing `PlacesUtils` file.

Back to Bug 1553454 Comment 8