Oh, that's interesting indeed. What's supposed to happen is that if we encounter a cert error, as it is common in some captive portals, we immediately recheck if there's a captive portal. However, I never considered what would happen if it failed for a http2 proxy :) I guess what we might want to do here is to put some rate limiting on RecheckCaptivePortal - if we last checked in the last 3 seconds (pref?) maybe we don't recheck at all. What do you think?
Bug 1553927 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Oh, that's interesting indeed. What's supposed to happen is that if we encounter a cert error, as it is common in some captive portals, we immediately recheck if there's a captive portal. However, I never considered what would happen if it failed for a http2 proxy :) I guess what we might want to do here is to put some rate limiting on `RecheckCaptivePortal` - if we last checked in the last 3 seconds (pref?) maybe we don't recheck at all. We already have `mLastChecked` that we can use for this. What do you think?