This ticket - it's patch should not depend in any on the localized top sites. What I understand though is that whatever build is failing with that error would be a multi-locale one containing the configs from bug 1564319. Those new configs would enable localized top sites depending on user's locale, top sites which would try to use local drawables when shown in the awesomescreen. So if the updated l1on packages (with the configs from bug 1564319) are part of release definitely the first and second patches from bug 1555950 should also be. (Patch 3 of bug 1555950 was necessary if these patches were to be landed before the l1on changes in bug 1564319 and so a lint error would be thrown because no code would actually use them. I think same would happen though with single-locale builds so patch 3 is also needed).
Bug 1557635 Comment 21 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
This ticket - it's patch should not depend in any on the localized top sites. What I understand though is that whatever build is failing with that error would be a multi-locale one containing the configs from bug 1564319. Those new configs would enable localized top sites depending on user's locale, top sites which would try to use local drawables when shown in the awesomescreen. So if the updated l1on packages (with the configs from bug 1564319) are part of release definitely the first and second patches from bug 1555950 should also be. (Patch 3 of bug 1555950 was necessary if these patches were to be landed before the l1on changes in bug 1564319 and so a lint error would be thrown because no code would actually use them. I think same would happen though with single-locale builds so patch 3 is also needed). With this green try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a2402e946976ec8a32400fa738a383cc17fb14d and the recent green PI test I'd say we're confident to land bug 1555950 but this would mean `Localized Top Sites` would be available right away in this release version, though they were tentatively planned for the `68.1 release` - bug 1555950 comment 33 Otherwise we would need to revert the changes from bug 1564319.
This ticket - it's patch should not depend in any on the localized top sites. What I understand though is that whatever build is failing with that error would be a multi-locale one containing the configs from bug 1564319. Those new configs would enable localized top sites depending on user's locale, top sites which would try to use local drawables when shown in the awesomescreen. So if the updated l1on packages (with the configs from bug 1564319) are part of release definitely the first and second patches from bug 1555950 should also be. (Patch 3 of bug 1555950 was necessary if these patches were to be landed before the l1on changes in bug 1564319 and so a lint error would be thrown because no code would actually use them. I think same would happen though with single-locale builds so patch 3 is also needed). With this green try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a2402e946976ec8a32400fa738a383cc17fb14d and the recent green PI test I'd say we're confident to land bug 1555950 but this would mean `Localized Top Sites` would be available right away in this release version, though they were tentatively planned for the `68.1 release` - bug 1555950 comment 33 Otherwise we would need to revert the changes from bug 1564319.
This ticket - it's patch should not depend in any on the localized top sites. What I understand though is that whatever build is failing with that error would be a multi-locale one containing the configs from bug 1564319. Those new configs would enable localized top sites depending on user's locale, top sites which would try to use local drawables when shown in the awesomescreen. So if the updated l1on packages (with the configs from bug 1564319) are part of release definitely the first and second patches from bug 1555950 should also be. (Patch 3 of bug 1555950 was necessary if these patches were to be landed before the l1on changes in bug 1564319 and so a lint error would be thrown because no code would actually use them. I think same would happen though with single-locale builds so patch 3 is also needed). With this green try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a2402e946976ec8a32400fa738a383cc17fb14d and the recent green PI test I'd say we're confident to land bug 1555950 but this would mean `Localized Top Sites` would be available right away in this release version, though they were tentatively planned for the `68.1 release` - bug 1555950 comment 33 Otherwise we would need to revert the changes from bug 1564319. NI-ing Chris to weigh on enabling `Localized Top Sites` now or later.
This ticket - it's patch should not depend in any on the localized top sites. What I understand though is that whatever build is failing with that error would be a multi-locale one containing the configs from bug 1564319. Those new configs would enable localized top sites depending on user's locale, top sites which would try to use local drawables when shown in the awesomescreen. So if the updated l1on packages (with the configs from bug 1564319) are part of release definitely the first and second patches from bug 1555950 should also be. (Patch 3 of bug 1555950 was necessary if these patches were to be landed before the l1on changes in bug 1564319 and so a lint error would be thrown because no code would actually use them. I think same would happen though with single-locale builds so patch 3 is also needed). With this green try https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a2402e946976ec8a32400fa738a383cc17fb14d and the recent green PI test I'd say we're confident to land bug 1555950 but this would mean `Localized Top Sites` would be available right away in this release version, though they were tentatively planned for the `68.1 release` - bug 1555950 comment 33 Otherwise we would need to revert the changes from bug 1564319. NI-ing Chris to weigh in on enabling `Localized Top Sites` now or later.