Bug 1558503 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to :Ehsan Akhgari from comment #17)
> I'd be happy to, but I'm not sure what you're suggesting specifically to do.  Can you please be more explicit about it (since I can see a few possibilities here).  Thanks!

Remove code that relies on intermediate interpolations of the strings, and use the strings directly.

There's only one possible defined format supported for properties placeholders (%S or %n$S), turns out we have code that replaces these placeables to inject HTML markup. The code should just should inject this markup in the original string.

I don't see how the current approach can scale. If we ever need a third placeable, we'll need another combination of characters to support it.
(In reply to :Ehsan Akhgari from comment #17)
> I'd be happy to, but I'm not sure what you're suggesting specifically to do.  Can you please be more explicit about it (since I can see a few possibilities here).  Thanks!

Remove code that relies on intermediate interpolations of the strings, and use the strings directly.

There's only one possible defined format supported for properties placeholders (%S or %n$S), turns out we have code that replaces these placeables, to then replace them a second time to inject HTML markup. The code should just should inject this markup in the original string.

I don't see how the current approach can scale. If we ever need a third placeable, we'll need another combination of characters to support it.

Back to Bug 1558503 Comment 18