Bug 1560676 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Drew Willcoxon :adw from comment #2)
> The simplest fix I found that still passes all our tests is limiting _strippedPrefix to a set of well known schemes.

we used to do this, iirc just for http and https, we changed it along with new origins autofill, that change caused other regressions, like for example bug 1503293 and bug 1642133... I think we should revert it to how it was before.
Revision 1 by
on 
(In reply to Drew Willcoxon :adw from comment #2)
> The simplest fix I found that still passes all our tests is limiting _strippedPrefix to a set of well known schemes.

we used to do this, iirc just for http and https, we changed it along with new origins autofill, that change caused other regressions, like for example bug 1503293 and bug 1642133 (maybe bug 1531335?)... I think we should revert it to how it was before.

Back to Bug 1560676 Comment 3