Bug 1560824 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
For comparison: Safari 12.1.1 on my mac mini shows equal heights for all three elements (select/button/input) in testcases 1 and 2.

And for testcase 3 (where they kind of get to define what "native theming" should look like), Safari has select and button having equal heights, with input only being 1px taller.  Here's the comparison:
```
                 Sel  Btn  Inp
Safari           18   18   19
Nightly          19   18   22
Patched Nightly  17   18   22
```
Bottom line, it looks like it's still legitimate to target buttons and select elements having the same height, and we should figure out what's responsible for the 1px sizing difference.
Revision 1 by
on 
For comparison: Safari 12.1.1 on my mac mini shows equal heights for all three elements (select/button/input) in testcases 1 and 2.

And for testcase 3 (where they kind of get to define what "native theming" should look like), Safari has select and button having equal heights, with input only being 1px taller.  Here's the comparison:
```
                 Sel  Btn  Inp
Safari           18   18   19
Nightly          19   18   22
Patched Nightly  17   18   22
```
Bottom line, it looks like it's still legitimate to aim for buttons and select elements having the same height under native theming (not to mention the same height as inputs as well, when unthemed) -- and we should figure out what's responsible for the 1px sizing difference.
Revision 2 by
on 
For comparison: Safari 12.1.1 on my mac mini shows equal heights for all three elements (select/button/input) in testcases 1 and 2.

And for testcase 3 (where they kind of get to define what "native theming" should look like), Safari has select and button having equal heights, with input only being 1px taller.  Here's the comparison:
```
                 Sel  Btn  Inp
Safari           18   18   19
Nightly          19   18   22
Patched Nightly  17   18   22
```
Bottom line, it looks like it's still legitimate to aim for buttons and select elements having the same height under native theming (not to mention the same height as textfield-inputs as well, when unthemed) -- and we should figure out what's responsible for the 1px sizing difference.
Revision 3 by
on 
For comparison: Safari 12.1.1 on my mac mini shows equal heights for all three elements (select/button/input) in testcases 1 and 2.

And for testcase 3 (where Safari kind of gets to define what "native theming" should look like), Safari has select and button having equal heights, with input only being 1px taller.  Here's the comparison:
```
                 Sel  Btn  Inp
Safari           18   18   19
Nightly          19   18   22
Patched Nightly  17   18   22
```
Bottom line, it looks like it's still legitimate to aim for buttons and select elements having the same height under native theming (not to mention the same height as textfield-inputs as well, when unthemed) -- and we should figure out what's responsible for the 1px sizing difference.

Back to Bug 1560824 Comment 11