(In reply to James Teh [:Jamie] from comment #2) > Strange. menulists should be excluded from arrow key navigation, regardless of whether they were focused by the key nav code or not: > https://searchfox.org/mozilla-central/rev/11712bd3ce7454923e5931fa92eaf9c01ef35a0a/browser/components/customizableui/PanelMultiView.jsm#1633 > We have a test for just this functionality: > https://searchfox.org/mozilla-central/rev/11712bd3ce7454923e5931fa92eaf9c01ef35a0a/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js#209 > I can't reproduce this on Windows. I don't have a Mac to test with. > Also, if this were a similar situation to bug 1547635, I'd expect that down arrow should focus the next control, rather than just doing nothing. It looks like clicking a menulist to open it on mac doesn't focus it, so `focus` is the window, so we set it to null because it's not inside the panel, so `tabOnly` returns false, and we focus the first/last node in the panel. Neil, what's the right way to detect this case, and/or is it even correct for the menulist not to take focus? (This is with "all controls" being focusable at the macOS level, so I would have expected menulists to be focusable and thus gain focus when clicked.)
Bug 1561581 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to James Teh [:Jamie] from comment #2) > Strange. menulists should be excluded from arrow key navigation, regardless of whether they were focused by the key nav code or not: > https://searchfox.org/mozilla-central/rev/11712bd3ce7454923e5931fa92eaf9c01ef35a0a/browser/components/customizableui/PanelMultiView.jsm#1633 > We have a test for just this functionality: > https://searchfox.org/mozilla-central/rev/11712bd3ce7454923e5931fa92eaf9c01ef35a0a/browser/components/customizableui/test/browser_PanelMultiView_keyboard.js#209 > I can't reproduce this on Windows. I don't have a Mac to test with. > Also, if this were a similar situation to bug 1547635, I'd expect that down arrow should focus the next control, rather than just doing nothing. It looks like clicking a menulist to open it on mac doesn't focus it, so `focus` in the code right above your link is the `<window>` node, so we set it to null because it's not inside the panel, so `tabOnly` returns false, and we focus the first/last node in the panel. Neil, what's the right way to detect this case, and/or is it even correct for the menulist not to take focus? (This is with "all controls" being focusable at the macOS level, so I would have expected menulists to be focusable and thus gain focus when clicked.)