(In reply to Patrick Cloke [:clokep] from comment #47) > Comment on attachment 9107615 [details] [diff] [review] > Bug-1562313_part-2_convert-chat-to-static-registration.patch > > Review of attachment 9107615 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good! I think I might have misspoken on my last comment, I think that > we should rename xmpp.jsm to xmpp-base.jsm and then xmpp.js to xmpp.jsm. > This patch renames xmpp.js to xmpp-base.jsm instead, which I think is > confusing since xmpp.jsm is the code used by all XMPP based protocols while > xmpp.js is the generic XMPP protocol. What do you think? > There were few changes only so I did it this way.
Bug 1562313 Comment 49 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Patrick Cloke [:clokep] from comment #47) > > Looks good! I think I might have misspoken on my last comment, I think that > we should rename xmpp.jsm to xmpp-base.jsm and then xmpp.js to xmpp.jsm. > This patch renames xmpp.js to xmpp-base.jsm instead, which I think is > confusing since xmpp.jsm is the code used by all XMPP based protocols while > xmpp.js is the generic XMPP protocol. What do you think? > There were few changes only so I did it this way.