Bugzilla

I think this is another new warning from bug 1560044 (showing up as an error in my build):

 0:13.29 In file included from /Users/amccreight/mc/obj-dbg.noindex/toolkit/xre/Unified_mm_toolkit_xre0.mm:2:
 0:13.29 /Users/amccreight/mc/toolkit/xre/MacApplicationDelegate.mm:348:46: error: conflicting parameter types in implementation of 'application:continueUserActivity:restorationHandler:': 'void (^ _Nonnull)(NSArray<id<NSUserActivityRestoring>> * _Nonnull)' vs 'void (^ _Nonnull)(NSArray *)' [-Werror,-Wmismatched-parameter-types]
 0:13.29       restorationHandler:(void (^)(NSArray*))restorationHandler {
 0:13.29                           ~~~~~~~~~~~~~~~~~~ ^
 0:13.29 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSApplication.h:405:187: note: previous definition is here
 0:13.29 - (BOOL)application:(NSApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void(^)(NSArray<id<NSUserActivityRestoring>> *restorableObjects))restorationHandler NS_AVAILABLE_MAC(10_10);
 0:13.29                                                                                                                          ~~~~~~                                                           ^
 0:13.29 1 error generated.

I confirmed that this happens with the changeset bug 1560044 landed in, but I haven't confirmed this is actually the regressor. But it seems pleasiable.

I think this is another new warning from bug 1560044 (showing up as an error in my build):

 0:13.29 In file included from /Users/amccreight/mc/obj-dbg.noindex/toolkit/xre/Unified_mm_toolkit_xre0.mm:2:
 0:13.29 /Users/amccreight/mc/toolkit/xre/MacApplicationDelegate.mm:348:46: error: conflicting parameter types in implementation of 'application:continueUserActivity:restorationHandler:': 'void (^ _Nonnull)(NSArray<id<NSUserActivityRestoring>> * _Nonnull)' vs 'void (^ _Nonnull)(NSArray *)' [-Werror,-Wmismatched-parameter-types]
 0:13.29       restorationHandler:(void (^)(NSArray*))restorationHandler {
 0:13.29                           ~~~~~~~~~~~~~~~~~~ ^
 0:13.29 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSApplication.h:405:187: note: previous definition is here
 0:13.29 - (BOOL)application:(NSApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void(^)(NSArray<id<NSUserActivityRestoring>> *restorableObjects))restorationHandler NS_AVAILABLE_MAC(10_10);
 0:13.29                                                                                                                          ~~~~~~                                                           ^
 0:13.29 1 error generated.

I confirmed that this happens with the changeset bug 1560044 landed in, but I haven't confirmed this is actually the regressor. But it seems plausible.