(In reply to Ryan VanderMeulen [:RyanVM] from comment #11) > (In reply to Sotaro Ikeda [:sotaro] from comment #4) > > Since Bug 1531898, WR frame re-build always happens. > > This patch hasn't landed on 69. Is that going to cause problems if we uplift this to Beta? Sorry, my comment was wrong. We do not need to uplift Bug 1531898. It addressed a different problem. Since Bug 1558106 fix in 69, we always need to re-build WR frame if there is an update. A cost of re-building WR frame becomes smaller. Then Bug 1552734 fix was not needed any more.
Bug 1565255 Comment 12 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #11) > (In reply to Sotaro Ikeda [:sotaro] from comment #4) > > Since Bug 1531898, WR frame re-build always happens. > > This patch hasn't landed on 69. Is that going to cause problems if we uplift this to Beta? Sorry, my comment was wrong. We do not need to uplift Bug 1531898. It addressed a bit different problem. Since Bug 1558106 fix in 69, we always need to re-build WR frame if there is an update. A cost of re-building WR frame becomes smaller. Then Bug 1552734 fix was not needed any more.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #11) > (In reply to Sotaro Ikeda [:sotaro] from comment #4) > > Since Bug 1531898, WR frame re-build always happens. > > This patch hasn't landed on 69. Is that going to cause problems if we uplift this to Beta? Sorry, my comment was wrong. We do not need to uplift Bug 1531898. It addressed a bit different problem. Since Bug 1558106 fix in 69, we always need to re-build WR frame if there is an update. A cost of re-building WR frame becomes smaller. Skipping re-build frame was already disabled by Bug 1559284. Then Bug 1552734 fix was not needed any more.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #11) > (In reply to Sotaro Ikeda [:sotaro] from comment #4) > > Since Bug 1531898, WR frame re-build always happens. > > This patch hasn't landed on 69. Is that going to cause problems if we uplift this to Beta? Sorry, my comment was wrong. We do not need to uplift Bug 1531898. It addressed a bit different problem. Since Bug 1558106 fix in 69, we always need to re-build WR frame if there is an update. A cost of re-building WR frame becomes smaller. Skipping re-build frame, but does WR rendering was already disabled by Bug 1559284. Then Bug 1552734 fix was not needed any more.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #11) > (In reply to Sotaro Ikeda [:sotaro] from comment #4) > > Since Bug 1531898, WR frame re-build always happens. > > This patch hasn't landed on 69. Is that going to cause problems if we uplift this to Beta? Sorry, my comment was wrong. We do not need to uplift Bug 1531898. It addressed a bit different problem. Since Bug 1558106 fix in 69, we always need to re-build WR frame if there is an update. A cost of re-building WR frame becomes smaller. Skipping re-build frame, but does WR rendering was already disabled by Bug 1559284. Then Bug 1552734 fix was not needed any more. Bug 1552734 was added to skip WR frame build if possible. It is not for reducing WR render.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #11) > (In reply to Sotaro Ikeda [:sotaro] from comment #4) > > Since Bug 1531898, WR frame re-build always happens. > > This patch hasn't landed on 69. Is that going to cause problems if we uplift this to Beta? Sorry, my comment was wrong. We do not need to uplift Bug 1531898. It addressed a bit different problem. Since Bug 1558106 fix in 69, we always need to re-build WR frame if there is an update. A cost of re-building WR frame becomes smaller. Skipping re-build frame, but does WR rendering was already disabled by Bug 1559284. Then Bug 1552734 fix was not needed any more. Bug 1552734 was added for skipping WR frame build if possible. It was not for reducing WR render.