Bug 1565384 Comment 17 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 from comment #16)
> although there are a bunch of remaining `bug` lines
True -- I think all of those files (all the .ini files that *just* have a bug line as the only annotation) are now stubs that don't do anything, & they can be removed.
 
Like this one:
https://hg.mozilla.org/mozilla-central/annotate/dbb4eb5782783c4bb3fb72169617741e0e78ec53/testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/images3/object-fit-contain-png-001e.html.ini

I can take care of that.

> and also a bunch of the PNG tests that still apparently fail with non-webrender.

Yeah -- we perhaps need to revert those .ini files their pre-bug 1559276 state (when they had some specific PASS conditions):
https://searchfox.org/mozilla-central/rev/1f9cb879fe48956c4a110e3a96c3e46dc03ddaca/testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/images3/object-fit-cover-png-001c.html.ini#3
...and/or annotate them as fuzzy instead of failing, if appropriate, depending on how the failure actually looks.  (I suspect the pre-bug 1559276 failure annotation predated our support for fuzzy annotations.)
(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 from comment #16)
> although there are a bunch of remaining `bug` lines

True -- I think all of those files (all the .ini files that *just* have a bug line as the only annotation) are now stubs that don't do anything, & they can be removed.
 
Like this one:
https://hg.mozilla.org/mozilla-central/annotate/dbb4eb5782783c4bb3fb72169617741e0e78ec53/testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/images3/object-fit-contain-png-001e.html.ini

I can take care of that.

> and also a bunch of the PNG tests that still apparently fail with non-webrender.

Yeah -- we perhaps need to revert those .ini files their pre-bug 1559276 state (when they had some specific PASS conditions):
https://searchfox.org/mozilla-central/rev/1f9cb879fe48956c4a110e3a96c3e46dc03ddaca/testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/images3/object-fit-cover-png-001c.html.ini#3
...and/or annotate them as fuzzy instead of failing, if appropriate, depending on how the failure actually looks.  (I suspect the pre-bug 1559276 failure annotation predated our support for fuzzy annotations.)
(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 from comment #16)
> although there are a bunch of remaining `bug` lines

True -- I think many of those files (all the .ini files that *just* have a bug line as the only annotation) are now stubs that don't do anything, & they can be removed.
 
Like this one:
https://hg.mozilla.org/mozilla-central/annotate/dbb4eb5782783c4bb3fb72169617741e0e78ec53/testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/images3/object-fit-contain-png-001e.html.ini

I can take care of that.

> and also a bunch of the PNG tests that still apparently fail with non-webrender.

Yeah -- we perhaps need to revert those .ini files their pre-bug 1559276 state (when they had some specific PASS conditions):
https://searchfox.org/mozilla-central/rev/1f9cb879fe48956c4a110e3a96c3e46dc03ddaca/testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/images3/object-fit-cover-png-001c.html.ini#3
...and/or annotate them as fuzzy instead of failing, if appropriate, depending on how the failure actually looks.  (I suspect the pre-bug 1559276 failure annotation predated our support for fuzzy annotations.)

Back to Bug 1565384 Comment 17