Bug 1566190 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #5)
> As a quick note for whoever implements this:
> 
> > [implement third-party sign-in, in such a way that Treeherder can hold user creds for multiple TC deployments at the same time](https://github.com/mozilla/treeherder/pull/5324#issue-312396711)
> 
> We will want to index the third-party logins by rootUrl, and allow a single treeherder instance to get and hold credentials for multiple Taskcluster deployments at the same time.  It's OK if that's a followup (the immediate need is to get credentials for the firefox-ci deployment), but it would be good to design with that in mind from the start.

So if I'm understanding this correctly, per your comment above and here: https://bugzilla.mozilla.org/show_bug.cgi?id=1574651#c9 we initially only need to hold credentials for the taskcluster.net rootUrl (which you've added as `tc_root_url` in the repositories.json fixture) but we'll also need to support other TC deployments that will have their own rootUrl's (such as the Servo https://community-tc.services.mozilla.com rootUrl mentioned in that bug).
(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #5)
> As a quick note for whoever implements this:
> 
> > [implement third-party sign-in, in such a way that Treeherder can hold user creds for multiple TC deployments at the same time](https://github.com/mozilla/treeherder/pull/5324#issue-312396711)
> 
> We will want to index the third-party logins by rootUrl, and allow a single treeherder instance to get and hold credentials for multiple Taskcluster deployments at the same time.  It's OK if that's a followup (the immediate need is to get credentials for the firefox-ci deployment), but it would be good to design with that in mind from the start.

So if I'm understanding this correctly, per your comment above and here: https://bugzilla.mozilla.org/show_bug.cgi?id=1574651#c9 we initially only need to hold credentials for the taskcluster.net rootUrl (which you've added as `tc_root_url` in the repositories.json fixture) but we'll also need to support other TC deployments that will have their own rootUrl's (such as the Servo https://community-tc.services.mozilla.com rootUrl mentioned in that bug). 

When a new rootUrl needs to be added, will that be a type file-a-bug-in-Treeherder type of process?
(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #5)
> As a quick note for whoever implements this:
> 
> > [implement third-party sign-in, in such a way that Treeherder can hold user creds for multiple TC deployments at the same time](https://github.com/mozilla/treeherder/pull/5324#issue-312396711)
> 
> We will want to index the third-party logins by rootUrl, and allow a single treeherder instance to get and hold credentials for multiple Taskcluster deployments at the same time.  It's OK if that's a followup (the immediate need is to get credentials for the firefox-ci deployment), but it would be good to design with that in mind from the start.

So if I'm understanding this correctly, per your comment above and here: https://bugzilla.mozilla.org/show_bug.cgi?id=1574651#c9 we initially only need to hold credentials for the taskcluster.net rootUrl (which you've added as `tc_root_url` in the repositories.json fixture) but we'll also need to support other TC deployments that will have their own rootUrl's (such as the Servo https://community-tc.services.mozilla.com rootUrl mentioned in that bug). 

When a new rootUrl needs to be added, will that be a file-a-bug-in-Treeherder type of process?

Back to Bug 1566190 Comment 11