Bug 1567245 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
In the [review][r] for a patch on bug 1564170 ("Give Debugger.Script instances their own NativeObject subclass, DebuggerScript"), jorendorff suggested the following cleanup:

> I'm guessing the ReferentVariant parameter here is fully determined by Wrapper; please remove it as a template parameter and make it a member typedef instead, Wrapper::ReferentVariant.
>
>(Actually I bet all 3 of the others are fully determined by Referent. This could be a lot nicer. Oh well!)
Revision 1 by
on 
In the [review][r] for a patch on bug 1564170 ("Give Debugger.Script instances their own NativeObject subclass, DebuggerScript"), jorendorff suggested the following cleanup:

> I'm guessing the ReferentVariant parameter here is fully determined by Wrapper; please remove it as a template parameter and make it a member typedef instead, Wrapper::ReferentVariant.
>
>(Actually I bet all 3 of the others are fully determined by Referent. This could be a lot nicer. Oh well!)

[r]: https://phabricator.services.mozilla.com/D37509#inline-230884

Back to Bug 1567245 Comment 0