Bug 1568755 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Chris Peterson [:cpeterson] from comment #5)
> (In reply to Alessio Placitelli [:Dexter] from comment #2)
> > This is for adding environment-like metrics to Gecko for them to show up in Fenix+Gecko data (from row 65 in [the spreadsheet](https://docs.google.com/spreadsheets/d/1EZGVGmybvF1sH-XrsXMlplK7fWQfDniIeqXrkfDQrlc/edit#gid=0)). These metrics should be instrumented by the teams requesting them. Is anyone working on this in other bugs?
> 
> Hi Alessio, I have a few questions:
> 
> * Are you asking here for the Graphics and Perf teams to now add their _environment_ metrics to Glean? And these are the same thing as scalar metrics?

To be precise: it's not adding their metrics to _Glean_, but adding them to _Gecko_ so that Glean can expose them. [Environment]() data from Desktop pings is just a bunch of scalar metrics that are not scalars yet. That's why we need teams to add Scalars. But we [have docs for that, too](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/start/report-gecko-telemetry-in-glean.html#reporting-a-scalar), with an example.

We can help with some of these, but we cannot do them all, as we're not really domain experts there (ideally people who add metrics/own metrics should know about these metrics).

> * I see that the Graphics team already instrumented some of their streaming metrics from the spreadsheet to metrics.yaml (like COMPOSITE_TIME bug 1580129, for example). Should I reach out to other Gecko teams and ask them to start instrumenting their streaming and scalar metrics to be collected in GeckoView?

There's these bunch of scalars/environment that are GFX related (from the usual spreadsheet):

- gfx_display_count
- gfx_display_h
- gfx_display_v
- gfx_adapter
- gfx_compositor
- gfx_status_webrender
- gfx_status_headless

It would be great if somebody from the GFX team could add the related scalars for them.
(In reply to Chris Peterson [:cpeterson] from comment #5)
> (In reply to Alessio Placitelli [:Dexter] from comment #2)
> > This is for adding environment-like metrics to Gecko for them to show up in Fenix+Gecko data (from row 65 in [the spreadsheet](https://docs.google.com/spreadsheets/d/1EZGVGmybvF1sH-XrsXMlplK7fWQfDniIeqXrkfDQrlc/edit#gid=0)). These metrics should be instrumented by the teams requesting them. Is anyone working on this in other bugs?
> 
> Hi Alessio, I have a few questions:
> 
> * Are you asking here for the Graphics and Perf teams to now add their _environment_ metrics to Glean? And these are the same thing as scalar metrics?

To be precise: it's not adding their metrics to _Glean_, but adding them to _Gecko_ so that Glean can expose them. [Environment](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/data/environment.html) data from Desktop pings is just a bunch of scalar metrics that are not scalars yet. That's why we need teams to add Scalars. But we [have docs for that, too](https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/start/report-gecko-telemetry-in-glean.html#reporting-a-scalar), with an example.

We can help with some of these, but we cannot do them all, as we're not really domain experts there (ideally people who add metrics/own metrics should know about these metrics).

> * I see that the Graphics team already instrumented some of their streaming metrics from the spreadsheet to metrics.yaml (like COMPOSITE_TIME bug 1580129, for example). Should I reach out to other Gecko teams and ask them to start instrumenting their streaming and scalar metrics to be collected in GeckoView?

There's these bunch of scalars/environment that are GFX related (from the usual spreadsheet):

- gfx_display_count
- gfx_display_h
- gfx_display_v
- gfx_adapter
- gfx_compositor
- gfx_status_webrender
- gfx_status_headless

It would be great if somebody from the GFX team could add the related scalars for them.

Back to Bug 1568755 Comment 6