### Beta/Release Uplift Approval Request * **User impact if declined**: Could easily skip over the one-time triplets cards from about:welcome instead of seeing them a bit more on new tabs * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: See QA scope: https://docs.google.com/document/d/16ZKPpOaPs3FLmTNePPNeNBjutCPRZrGeScDQMtWPYSA/edit#heading=h.fwc5z5t7r484 Set `app.normandy.user_id` to a string pref value `99` to test "holdback" experiment (i.e., no triplets on new tabs). * **List of other uplifts needed**: 1567601 1569300 * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: The patch for uplift is on top of both bug 1567601 and bug 1569300 that touch some shared code. The behavior changes are relatively straightforward of additionally showing the about:welcome cards on new tabs although the patch is somewhat large as it includes refactoring to show the triplets on more than just about:welcome. Given the startup nature of showing about:welcome or about:home early, experimentation is built in like how it was done for Trailhead 67 dot release. https://treeherder.mozilla.org/#/jobs?repo=try&revision=47323c8cff2315013e1dcd373d067670c4536583 * **String changes made/needed**: none
Bug 1569303 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
### Beta/Release Uplift Approval Request * **User impact if declined**: Could easily skip over the one-time triplets cards from about:welcome instead of seeing them a bit more on new tabs * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: See QA scope: https://docs.google.com/document/d/16ZKPpOaPs3FLmTNePPNeNBjutCPRZrGeScDQMtWPYSA/edit#heading=h.fwc5z5t7r484 Set `app.normandy.user_id` to a string pref value `99` to test "holdback" experiment (i.e., no triplets on new tabs). * **List of other uplifts needed**: bug 1567601 and bug 1569300 * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: The patch for uplift is on top of both bug 1567601 and bug 1569300 that touch some shared code. The behavior changes are relatively straightforward of additionally showing the about:welcome cards on new tabs although the patch is somewhat large as it includes refactoring to show the triplets on more than just about:welcome. Given the startup nature of showing about:welcome or about:home early, experimentation is built in like how it was done for Trailhead 67 dot release. https://treeherder.mozilla.org/#/jobs?repo=try&revision=47323c8cff2315013e1dcd373d067670c4536583 * **String changes made/needed**: none
Includes 10 bugs: https://bugzilla.mozilla.org/buglist.cgi?bug_id=1560065%2C1560065%2C1568909%2C1570026%2C1571817%2C1572378%2C0024397%2C1570754%2C1570481%2C1571442%2C1573209 ### Beta/Release Uplift Approval Request * **User impact if declined**: Could easily skip over the one-time triplets cards from about:welcome instead of seeing them a bit more on new tabs * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: See QA scope: https://docs.google.com/document/d/16ZKPpOaPs3FLmTNePPNeNBjutCPRZrGeScDQMtWPYSA/edit#heading=h.fwc5z5t7r484 Set `app.normandy.user_id` to a string pref value `99` to test "holdback" experiment (i.e., no triplets on new tabs). * **List of other uplifts needed**: bug 1567601 and bug 1569300 * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: The patch for uplift is on top of both bug 1567601 and bug 1569300 that touch some shared code. The behavior changes are relatively straightforward of additionally showing the about:welcome cards on new tabs although the patch is somewhat large as it includes refactoring to show the triplets on more than just about:welcome. Given the startup nature of showing about:welcome or about:home early, experimentation is built in like how it was done for Trailhead 67 dot release. https://treeherder.mozilla.org/#/jobs?repo=try&revision=47323c8cff2315013e1dcd373d067670c4536583 * **String changes made/needed**: none
Includes 9 bugs: https://bugzilla.mozilla.org/buglist.cgi?bug_id=1560065%2C1568909%2C1570026%2C1571817%2C1572378%2C1570754%2C1570481%2C1571442%2C1573209 ### Beta/Release Uplift Approval Request * **User impact if declined**: Could easily skip over the one-time triplets cards from about:welcome instead of seeing them a bit more on new tabs * **Is this code covered by automated tests?**: Yes * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: See QA scope: https://docs.google.com/document/d/16ZKPpOaPs3FLmTNePPNeNBjutCPRZrGeScDQMtWPYSA/edit#heading=h.fwc5z5t7r484 Set `app.normandy.user_id` to a string pref value `99` to test "holdback" experiment (i.e., no triplets on new tabs). * **List of other uplifts needed**: bug 1567601 and bug 1569300 * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: The patch for uplift is on top of both bug 1567601 and bug 1569300 that touch some shared code. The behavior changes are relatively straightforward of additionally showing the about:welcome cards on new tabs although the patch is somewhat large as it includes refactoring to show the triplets on more than just about:welcome. Given the startup nature of showing about:welcome or about:home early, experimentation is built in like how it was done for Trailhead 67 dot release. https://treeherder.mozilla.org/#/jobs?repo=try&revision=47323c8cff2315013e1dcd373d067670c4536583 * **String changes made/needed**: none