Bug 1571643 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Hrmm, looking at the `JobModel.retriggerJob` again it seems you need push_ids, not job_ids. Cam, can a job be retriggered  with a job id?

If you need push_ids then you'll need to modify the `/performance/summary` endpoint to return that field.  Also that whole `JobModel` class and method is using `notify` which is something Treeherder uses for all of its notifications. Perfherder uses `errorMessages` at the top level component, which is the `validation` higher order component. I think you'll need to extract whats needed from that `retrigger` method to adapt to Perfherder's requirements.

Also please do not use jquery as you have here: https://github.com/mozilla/treeherder/compare/master...alexandru-io:retrigger_compare_view?expand=1#diff-645b8f7bcdcc827feda0e8ddd69c6774R38

We have deprecated it's use and setting a spinner or any other `className` attribute is easy enough to do using react state. There's a loading spinner component you can use in the `ui/shared` file.
Hrmm, looking at the `JobModel.retriggerJob` again it seems you need push_ids, not job_ids. Cam, can a job be retriggered  with a job id?

If you need push_ids then you'll need to modify the `/performance/summary` endpoint to return that field.  Also that whole `JobModel` class and method is using `notify` which is something Treeherder uses for all of its notifications. Perfherder uses `errorMessages` at the top level component, which is the `validation` higher order component. I think you'll need to extract whats needed from that `retrigger` method to adapt to Perfherder's requirements (possibly putting some shared logic in one of our `ui/helpers` files).

Also please do not use jquery as you have here: https://github.com/mozilla/treeherder/compare/master...alexandru-io:retrigger_compare_view?expand=1#diff-645b8f7bcdcc827feda0e8ddd69c6774R38

We have deprecated it's use and setting a spinner or any other `className` attribute is easy enough to do using react state. There's a loading spinner component you can use in the `ui/shared` file.

Back to Bug 1571643 Comment 9