Bug 1573051 Comment 30 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: This is a fix for a functionality regression.

Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link to "microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18" should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.

On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.

This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String changes made/needed**: None

### ESR Uplift Approval Request
* **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: This bug is critical for an enterprise customer using an application using custom URIs.  For example, Bug 1574209 complained SSO was broken due to this bug.
* **User impact if declined**: This is a fix for a functionality regression.

Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link to "microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18" should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.

On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Fix Landed on Version**: 70.0a1
* **Risk to taking this patch**: High
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.

This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String or UUID changes made by this patch**: None
Revision 1 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: This is a fix for a functionality regression.

Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link to [microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18](microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18) should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.

On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.

This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String changes made/needed**: None

### ESR Uplift Approval Request
* **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: This bug is critical for an enterprise customer using an application using custom URIs.  We already had Bug 1574209 complaining that SSO was broken due to this bug.
* **User impact if declined**: This is a fix for a functionality regression.

Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link to "microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18" should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.

On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Fix Landed on Version**: 70.0a1
* **Risk to taking this patch**: High
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.

This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String or UUID changes made by this patch**: None
Revision 2 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: This is a fix for a functionality regression.  Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link to [microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18](microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18) should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.  On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.  This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String changes made/needed**: None

### ESR Uplift Approval Request
* **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: This bug is critical for an enterprise customer using an application using custom URIs.  We already had Bug 1574209 complaining that SSO was broken due to this bug.
* **User impact if declined**: This is a fix for a functionality regression.  Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link to "microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18" should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.  On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Fix Landed on Version**: 70.0a1
* **Risk to taking this patch**: High
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.  This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String or UUID changes made by this patch**: None
Revision 3 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: This is a fix for a functionality regression.  Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link [microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18](microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18) should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.  On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.  This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String changes made/needed**: None

### ESR Uplift Approval Request
* **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: This bug is critical for an enterprise customer using an application using custom URIs.  We already had Bug 1574209 complaining that SSO was broken due to this bug.
* **User impact if declined**: This is a fix for a functionality regression.  Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link [microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18](microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18) should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.  On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Fix Landed on Version**: 70.0a1
* **Risk to taking this patch**: High
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.  This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String or UUID changes made by this patch**: None
Revision 4 by
on 
### Beta/Release Uplift Approval Request
* **User impact if declined**: This is a fix for a functionality regression.  Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link [microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18](microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18) should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.  On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Is this code covered by automated tests?**: Yes
* **Has the fix been verified in Nightly?**: Yes
* **Needs manual test from QE?**: No
* **If yes, steps to reproduce**: 
* **List of other uplifts needed**: None
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.  This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String changes made/needed**: None

### ESR Uplift Approval Request
* **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: This bug is critical for an enterprise customer using an application using custom URIs.  We already had Bug 1574209 complaining that SSO was broken due to this bug.
* **User impact if declined**: This is a fix for a functionality regression.  Without this patch, a link with an external protocol does not work correctly if it contains a fragment.  For example, a link [microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18](microsoft-edge:https://bugzilla.mozilla.org/show_bug.cgi?id=1573051#c18) should launch Microsoft Edge on Windows 10 and navigate to the comment on Bugzilla, but the fragment "#c18" is dropped due to this bug, thus Edge is not navigated to the comment.  On Thunderbird, this issue could be more common because http(s) is considered as an external protocol.
* **Fix Landed on Version**: 70.0a1
* **Risk to taking this patch**: Low
* **Why is the change risky/not risky? (and alternatives if risky)**: The change is not risky because the impacted scenario is limited, a link uses an external uri and a fragment. We changed the validation logic for a uri in that scenario.  This change added a unittest to verify the same result from both of the old/new uri validation logics.
* **String or UUID changes made by this patch**: None

Back to Bug 1573051 Comment 30