(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #31) > As I noted above we wouldn't have to. All the bits and pieces > which needed are in a different repository. Once that other patch > lands, and get published, we would only have to re-run the signing > job for MacOS. We could than take the newly generated binary. > > Maybe we can just replace the binary of the 0.26.0 release on the > Github release page once the issue has been fixed? Given that > there are no code changes, we would still have the exact same bits > in it. But not sure if Github allows that. OK, good! That will inevitably change the binary, but since we don’t yet publish signature files for macOS I suppose that would be acceptable. GitHub does allow us replace the attached assets. > (In reply to Andreas Tolfsen 「:ato」 from comment #29) > > I published all the signed release packages of geckodriver > > 0.26.0 from [e9783a644016] but I could only find a `Windows > > 2012 opt` job with the signature `Windows 2012 opt Geckodriver geckodriver-signing-win32-nightly/opt Gd(s)`. > > I uploaded the Windows 32-bit .zip package, but where > > do I find the 64-bit package? > > Not sure why those weren't running. If that happens again we > should report a bug. For now I triggered the win64 repack > and signing job but just using the "Add new jobs" feature of > Treeherder. Thanks! 🙌🏻 Let’s keep an eye on `Gd(s)` in the future. [e9783a644016]: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=geckodriver&revision=e9783a644016aa9b317887076618425586730d73&selectedJob=270805027)
Bug 1573798 Comment 34 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #31) > As I noted above we wouldn't have to. All the bits and pieces > which needed are in a different repository. Once that other patch > lands, and get published, we would only have to re-run the signing > job for MacOS. We could than take the newly generated binary. > > Maybe we can just replace the binary of the 0.26.0 release on the > Github release page once the issue has been fixed? Given that > there are no code changes, we would still have the exact same bits > in it. But not sure if Github allows that. OK, good! That will inevitably change the binary, but since we don’t yet publish signature files for macOS I suppose that would be acceptable. GitHub does allow us replace the attached assets. > (In reply to Andreas Tolfsen 「:ato」 from comment #29) > > I published all the signed release packages of geckodriver > > 0.26.0 from [e9783a644016] but I could only find a `Windows > > 2012 opt` job with the signature `Windows 2012 opt Geckodriver geckodriver-signing-win32-nightly/opt Gd(s)`. > > I uploaded the Windows 32-bit .zip package, but where > > do I find the 64-bit package? > > Not sure why those weren't running. If that happens again we > should report a bug. For now I triggered the win64 repack > and signing job but just using the "Add new jobs" feature of > Treeherder. Thanks! 🙌🏻 Let’s keep an eye on `Gd(s)` in the future. [e9783a644016]: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=geckodriver&revision=e9783a644016aa9b317887076618425586730d73&selectedJob=270805027