### Beta/Release Uplift Approval Request * **User impact if declined**: Users with specific usernames, such as a dot at the end of their username, will be unable to update Firefox and Firefox will be unable to start without manual removal of a hard-to-find upgrade directory. * **Is this code covered by automated tests?**: No * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: Since this addresses an issue when updating Firefox, at least two subsequent builds with this patch are required before verification of this fix is possible. 1. Create a username with a dot at the end of it, such as `testuser.`. 2. Install a first build that has this fix. 3. Open the about dialog to download an update and apply it. 4. Verify that the new version starts. * **List of other uplifts needed**: None * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: This is a well-understood fix to address the way we verify valid file paths. * **String changes made/needed**: none ### ESR Uplift Approval Request * **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: Risk of update orphaning and possible drop in user numbers (although the number of affected users is believed to be small) * **User impact if declined**: Users with specific usernames, such as a dot at the end of their username, will be unable to update Firefox and Firefox will be unable to start without manual removal of a hard-to-find upgrade directory. * **Fix Landed on Version**: 77 * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: This is a well-understood fix to address the way we verify valid file paths. * **String or UUID changes made by this patch**: none
Bug 1574139 Comment 34 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
### Beta/Release Uplift Approval Request * **User impact if declined**: Users with specific usernames, such as a dot at the end of their username, will be unable to update Firefox and Firefox will be unable to start without manual removal of a hard-to-find upgrade directory. * **Is this code covered by automated tests?**: No * **Has the fix been verified in Nightly?**: Yes * **Needs manual test from QE?**: Yes * **If yes, steps to reproduce**: Since this addresses an issue when updating Firefox, at least two subsequent builds with this patch are required before verification of this fix is possible. 1. Create a username with a dot at the end of it, such as `testuser.`, and switch to it. 2. Install a first build that has this fix. 3. Open the about dialog to download an update and apply it. 4. Verify that the new version starts. * **List of other uplifts needed**: None * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: This is a well-understood fix to address the way we verify valid file paths. * **String changes made/needed**: none ### ESR Uplift Approval Request * **If this is not a sec:{high,crit} bug, please state case for ESR consideration**: Risk of update orphaning and possible drop in user numbers (although the number of affected users is believed to be small) * **User impact if declined**: Users with specific usernames, such as a dot at the end of their username, will be unable to update Firefox and Firefox will be unable to start without manual removal of a hard-to-find upgrade directory. * **Fix Landed on Version**: 77 * **Risk to taking this patch**: Low * **Why is the change risky/not risky? (and alternatives if risky)**: This is a well-understood fix to address the way we verify valid file paths. * **String or UUID changes made by this patch**: none