Bug 1575016 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

In [`nsColumnSetFrame::ChooseColumnStrategy()`](https://searchfox.org/mozilla-central/rev/428cf94f4ddfb80eebc6028023a7d89eb277791b/layout/generic/nsColumnSetFrame.cpp#406-414), we made the choice of minimun column-box block-size of 1px on _non_-balancing columns by

```
    // XXX_jwir3: If a page's height is set to 0, we could continually
    //            create continuations, resulting in an infinite loop, since
    //            no progress is ever made. This is an issue with the spec
    //            (css3-multicol, css3-page, and css3-break) that is
    //            unresolved as of 27 Feb 2013. For the time being, we set this
    //            to have a minimum of 1 css px. Once a resolution is made
    //            on what minimum to have for a page height, we may need to
    //            change this value to match the appropriate spec(s).
    colBSize = std::max(colBSize, nsPresContext::CSSPixelsToAppUnits(1));
```

I find that the [fragmentation spec](https://drafts.csswg.org/css-break/#breaking-rules) says,

> To guarantee progress, fragmentainers are assumed to have a minimum block size of 1px regardless of their used size. 

That is, we can update the comments, and maybe invesitgate whether we should also apply the 1px minimun block-size when doing column-balancing. (I feel we should.)
In [`nsColumnSetFrame::ChooseColumnStrategy()`](https://searchfox.org/mozilla-central/rev/428cf94f4ddfb80eebc6028023a7d89eb277791b/layout/generic/nsColumnSetFrame.cpp#406-414), we made the choice of minimun column-box block-size of 1px on _non_-balancing columns by

```
    // XXX_jwir3: If a page's height is set to 0, we could continually
    //            create continuations, resulting in an infinite loop, since
    //            no progress is ever made. This is an issue with the spec
    //            (css3-multicol, css3-page, and css3-break) that is
    //            unresolved as of 27 Feb 2013. For the time being, we set this
    //            to have a minimum of 1 css px. Once a resolution is made
    //            on what minimum to have for a page height, we may need to
    //            change this value to match the appropriate spec(s).
    colBSize = std::max(colBSize, nsPresContext::CSSPixelsToAppUnits(1));
```

I find that the [fragmentation spec](https://drafts.csswg.org/css-break/#breaking-rules) says,

> To guarantee progress, fragmentainers are assumed to have a minimum block size of 1px regardless of their used size. 

That is, we can update the comments, and maybe investigate whether we should also apply the 1px minimum block-size when doing column-balancing. (I feel we should.)

Back to Bug 1575016 Comment 0