(In reply to Liz Henry (:lizzard) from comment #13) > Comment on attachment 9088907 [details] > Bug 1577035 - Cache Monitor data to reduce the load on Monitor API. > > Perf improvement for Skyline feature, let's uplift for beta 6. > Is there any particular verification you would like to see here (in beta?) This can be verified as working by two things. One - open a new Firefox with a new profile. - go to about:protections - click the "sign up for breach alerts" button and subscribe - log in to the browser with your firefox account - go back to about:protections, refresh the page, the monitor card should now have your breach alert stats. (there was no caching) Two - go back to the monitor page (*not* through clicking the "View full report on Firefox Monitor" link) - unsubscribe from breach alerts - go back to about:protections and refresh the page - you should still see the monitor data for another 24 hours due to caching. - clicking on the "View full report on Firefox Monitor" link will invalidate the cache. As for performance, we are unsure of what sort of load to expect on the Monitor API so we are taking this precaution. (is that the sort of information you mean by "verification"?)
Bug 1577035 Comment 14 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Liz Henry (:lizzard) from comment #13) > Comment on attachment 9088907 [details] > Bug 1577035 - Cache Monitor data to reduce the load on Monitor API. > > Perf improvement for Skyline feature, let's uplift for beta 6. > Is there any particular verification you would like to see here (in beta?) This can be verified as working by two things. One - open a new Firefox with a new profile. - go to about:protections - click the "sign up for breach alerts" button and subscribe - log in to the browser with your firefox account - go back to about:protections, refresh the page, the monitor card should now have your breach alert stats. (there was no caching) Two - go back to the monitor page (*not* through clicking the "View full report on Firefox Monitor" link) - unsubscribe from breach alerts - go back to about:protections and refresh the page - you should still see the monitor data for another 24 hours due to caching. - clicking on the "View full report on Firefox Monitor" link will invalidate the cache. As for performance, we are unsure of what sort of load to expect on the Monitor API so we are taking this precaution. (is that the sort of information you mean by "verification"?)