Bugzilla

Hi emilio, I was told you could help me out here.

In the patch attached here I'm attempting to unify how the various panel headers are being created and displayed.
After making the needed changes, I got to a state in which the identity panel (when visiting https://permission.site/ for example) and the permissions panel are being cut off from the bottom.
Somewhat related, the edit bookmark panel gets a permanent scrollbar no matter what (or how many) items I try to set `display: none` on.
All 3 panels get fixed if I either:
1. Replace the `min-height` of `.panel-header` in `panelUI-shared.css` with `height` (which is not a good fix because I want it to expand when the text inside is lengthy), or
2. Add `overflow: hidden` to `.panel-header`. This has no negative side effect AFAICS.

This raises a few questions though:
1. Is the `overflow: hidden` addition the right fix? If so, why? If not, what would you suggest as an alternative?
2. If I rename the permissions panel header to, say, 8 times of the following: `Permissions for permission.site` (with a whitespace between each repetition) and toggle `overflow: hidden` on and off, I can see a difference in the padding. Not a big deal but annoying. Anything that can be done about this? (ignore this question if `overflow: hidden` is not the solution)

Thanks!

Hi emilio, I was told you could help me out here.

In the patch attached here I'm attempting to unify how the various panel headers are being created and displayed.
After making the needed changes, I got to a state in which the identity panel (when visiting https://permission.site/ for example) and the permissions panel are being cut off from the bottom. The hacky workaround I found to this was to add `-moz-box-flex: 1` to them.
Somewhat related, the edit bookmark panel gets a permanent scrollbar no matter what (or how many) items I try to set `display: none` on.
All 3 panels get fixed if I either:
1. Replace the `min-height` of `.panel-header` in `panelUI-shared.css` with `height` (which is not a good fix because I want it to expand when the text inside is lengthy), or
2. Add `overflow: hidden` to `.panel-header`. This has no negative side effect AFAICS.

This raises a few questions though:
1. Is the `overflow: hidden` addition the right fix? If so, why? If not, what would you suggest as an alternative?
2. If I rename the permissions panel header to, say, 8 times of the following: `Permissions for permission.site` (with a whitespace between each repetition) and toggle `overflow: hidden` on and off, I can see a difference in the padding. Not a big deal but annoying. Anything that can be done about this? (ignore this question if `overflow: hidden` is not the solution)

Thanks!