Bugzilla

(In reply to Simon Giesecke [:sg] [he/him] from comment #4)
> @jstutte, you made the following comments last week:
> * "Have the coding style open at reviews, amend it as needed. How to agree in team?" The first sentence should be included in the review process description (I am not sure if you took on to write that down?) I am not sure what the question in the second sentence refers to. Agree on what?
The question was, what should the process look like to agree on amendments to the coding style in order to ensure acceptance by the team. You already have written an answer to this with the bugzilla process and double r+, which should ensure an acceptable level of sharing without blocking everybody.

> * "Who should do 'coding style update' review? All team? Vote?" That's a good question, and it should be addressed in the coding style evolution process description I am going to write to resolve this bug. I think changes to the coding style should be reviewed on the one hand by an owner of the coding style document (which I would volunteer to be for now), on the other hand by someone with good familiarity with large parts of the local code base, and if either coincides with the author of the coding style change, by two other team members in total. Requiring the complete team to review or vote would pose too many obstacles IMO. The coding style can be changed, so any concerns can be raised at any time after an amendment has been included in the style document originally.
You already wrote this process, and it seems reasonable to me. I would give it a try like this and adjust if we encounter problems.

(In reply to Simon Giesecke [:sg] [he/him] from comment #4)
> @jstutte, you made the following comments last week:
> * "Have the coding style open at reviews, amend it as needed. How to agree in team?" The first sentence should be included in the review process description (I am not sure if you took on to write that down?) I am not sure what the question in the second sentence refers to. Agree on what?

The question was, what should the process look like to agree on amendments to the coding style in order to ensure acceptance by the team. You already have written an answer to this with the bugzilla process and double r+, which should ensure an acceptable level of sharing without blocking everybody.

> * "Who should do 'coding style update' review? All team? Vote?" That's a good question, and it should be addressed in the coding style evolution process description I am going to write to resolve this bug. I think changes to the coding style should be reviewed on the one hand by an owner of the coding style document (which I would volunteer to be for now), on the other hand by someone with good familiarity with large parts of the local code base, and if either coincides with the author of the coding style change, by two other team members in total. Requiring the complete team to review or vote would pose too many obstacles IMO. The coding style can be changed, so any concerns can be raised at any time after an amendment has been included in the style document originally.

You already wrote this process, and it seems reasonable to me. I would give it a try like this and adjust if we encounter problems.