Bug 1578463 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Review of attachment 9090118 [details] [diff] [review]:
-----------------------------------------------------------------

Yes I think this is correct by code inspection. Manipulating 'onacceptdialog' attributes is dead anyway. But I tested all the codepaths (except selectDialog) and the "on accept" functions seem to be called where expected.
The read-only cards and addressbooks do NOT run the "on accept" functions, as intended.
The am-smime calls smimeSave() properly, whether it is inside the account manager pane, or in the standalone dialog in am-identity-edit.xul.
Revision 1 by
on 
Review of attachment 9090118 [details] [diff] [review]:
-----------------------------------------------------------------

Yes I think this is correct by code inspection. Manipulating 'ondialogaccept' attributes is dead anyway. But I tested all the codepaths (except selectDialog) and the "on accept" functions seem to be called where expected.
The read-only cards and addressbooks do NOT run the "on accept" functions, as intended.
The am-smime calls smimeSave() properly, whether it is inside the account manager pane, or in the standalone dialog in am-identity-edit.xul.

Back to Bug 1578463 Comment 4