Bug 1557689 fixed a major bug in our Inactive CSS engine but also introduced a new bug. In `inactive-property-helper.js` we first cache all of the `invalid properties` (properties that are not valid for the current element) for which we have validators and act only when these properties match: https://searchfox.org/mozilla-central/source/devtools/server/actors/utils/inactive-property-helper.js#189-196,246 The problem is that we also had the ability to act on `valid properties` (properties that are valid for the current element). This functionality is currently unused and would significantly slow down the Inactive CSS engine so we should remove it. To fix this we just need to remove all references to `validProperties` from `devtools/server/actors/utils/inactive-property-helper.js`.
Bug 1579058 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Bug 1557689 fixed a major bug in our Inactive CSS engine but also introduced a new bug. In `inactive-property-helper.js` we first cache all of the `invalid properties` (properties that are not valid for the current element) for which we have validators and act only when these properties match: https://searchfox.org/mozilla-central/source/devtools/server/actors/utils/inactive-property-helper.js#189-196,246 The problem is that we also had the ability to act on `valid properties` (properties that are valid for the current element). This functionality is broken and currently unused and would significantly slow down the Inactive CSS engine so we should remove it. To fix this we just need to remove all references to `validProperties` from `devtools/server/actors/utils/inactive-property-helper.js`.
Bug 1557689 fixed a major bug in our Inactive CSS engine but also introduced a new bug. In `inactive-property-helper.js` we first cache all of the `invalid properties` (properties that are not valid for the current element) for which we have validators and act only when these properties match: https://searchfox.org/mozilla-central/source/devtools/server/actors/utils/inactive-property-helper.js#189-196,246 The problem is that we also had the ability to act on `valid properties` (properties that are valid for the current element). This functionality is broken, currently unused and would significantly slow down the Inactive CSS engine so we should remove it. To fix this we just need to remove all references to `validProperties` from `devtools/server/actors/utils/inactive-property-helper.js`.
Bug 1557689 fixed a major bug in our Inactive CSS engine but also broke the ability to act on `valid properties` (properties that are valid for the current element). This functionality is broken, currently unused and would significantly slow down the Inactive CSS engine if we did use it so we should remove it. To fix this we just need to remove all references to `validProperties` from `devtools/server/actors/utils/inactive-property-helper.js`.