Bugzilla

(In reply to Drew Willcoxon :adw from comment #13)
> It looks like we limit search suggestions and SQL row fetches to `_maxResults`, but there's no limit at all placed on remote tabs? We just call `_addMatch` on every remote tab returned by `PlacesRemoteTabsAutocompleteProvider`. Is it as simple as that, am I reading that right?

that's right, the remote tabs query seems unbound, good catch. It should be limited to maxRichResults.

(In reply to Drew Willcoxon :adw from comment #13)
> It looks like we limit search suggestions and SQL row fetches to `_maxResults`, but there's no limit at all placed on remote tabs? We just call `_addMatch` on every remote tab returned by `PlacesRemoteTabsAutocompleteProvider`. Is it as simple as that, am I reading that right?

that's right, the remote tabs query seems unbound, good catch. It should be limited to maxRichResults.

Edit: and likely the provider itself should not lose time fetching things we don't care about.

(In reply to Drew Willcoxon :adw from comment #13)
> It looks like we limit search suggestions and SQL row fetches to `_maxResults`, but there's no limit at all placed on remote tabs? We just call `_addMatch` on every remote tab returned by `PlacesRemoteTabsAutocompleteProvider`. Is it as simple as that, am I reading that right?

that's right, the remote tabs query seems unbound, good catch. It should be limited to maxRichResults.

Edit: and likely the provider itself should not lose time fetching things we don't care about, we could change its fetch method to take a maxResults