Bug 1579539 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

As it is possible to change both the username and password from the password-change doorhanger, we should always pass the autoSavedLoginGuid param to promptToChangePassword, when an autosaved (generated-password) login on that origin exists. 

From bug 1560042, these STR: 
 
> LoginA= Complete credentials with username and password
> LoginB= No username/GeneratedPasw
> 
>     LoginA autocomplete before generated password: FIXED
> 
>     Have LoginA saved and auto-filled in the fields
>     Delete password and generate a new one via the context menu or select LoginB for the password
> 
>     Auto-filled generated password and existing username addition: BROKEN
> 
>     Have loginA saved credentials
>     Have loginB no username generated password entry
>     Autocomplete password for loginB
>     Type in the same username as in loginA in the field and click on Update in the doorhanger -> entries will NOT BE MERGED
As it is possible to change both the username and password from the password-change doorhanger, we should always pass the autoSavedLoginGuid param to promptToChangePassword, when an autosaved (generated-password) login on that origin exists. 

From bug 1560042, these STR: 
 
> LoginA= Complete credentials with username and password
> LoginB= No username/GeneratedPasw
> 
>     Have LoginA saved and auto-filled in the fields
>     Delete password and generate a new one via the context menu or select LoginB for the password
> 
>     Auto-filled generated password and existing username addition: BROKEN
> 
>     Have loginA saved credentials
>     Have loginB no username generated password entry
>     Autocomplete password for loginB
>     Type in the same username as in loginA in the field and click on Update in the doorhanger -> entries will NOT BE MERGED
As it is possible to change both the username and password from the password-change doorhanger, we should always pass the autoSavedLoginGuid param to promptToChangePassword, when an autosaved (generated-password) login on that origin exists. 

This bug was found during verification of bug 1560042, see comments there for more context.  

STR: 
* From https://twitter.com/login, save a new login by entering "user1" as username and password "password123" in the form, 
* Click "Log in" and confirm the save-password prompt that appears
* Load https://twitter.com/login again, clear out any autofilled fields
* Focus the password field and enter a generated password from the context menu (right-click, "Fill Password" ->  "Use a securely generated password"
* (a confirmation hint shows up confirming the auto-saving of a new login with this password)
* Type in "user1" into the username field and submit the form
* When the "Update this login" doorhanger appears, confirm it with no changes to username or password values in the prompt fields. 
* Load about:logins to examine the outcome

ER: 
* A single login for twitter.com, with username "user1" and the generated password value

AR:  
* A "user1" login with unchanged password "password123"
* A "" (no username) login with the generated password
* In the console a "Unexpected match of multiple logins" error is logged

Back to Bug 1579539 Comment 0